New issue
Advanced search Search tips

Issue 778407 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Cros splitview - The splitview indicator is not as intended in rtl and longer languages.

Project Member Reported by sammiequon@chromium.org, Oct 25 2017

Issue description

See attached screenshot, which is in Hebrew, a rtl and language which is longer for this particular string.

https://screenshot.googleplex.com/74OBGxeTNwC
 
omrillio@ - can you let the translations team that the translation in hebrew is incorrect?
We should probably also increase the max width of the message to accommodate for languages that take longer than English.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e6f2699b135ca4b2f591275b84da32724dbc1aa

commit 7e6f2699b135ca4b2f591275b84da32724dbc1aa
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Oct 27 16:42:52 2017

splitview: Make splitview indicator more localizable.

Rotate the opposite direction for landscape in rtl, so rtl users look the
same way as ltr users.
Use preferred size instead of fixed for the text, this will look better
and also scale better for longer languages.

Screenshot: https://screenshot.googleplex.com/KPRjTcZ0ib1

Test: manual
Bug:  778407 
Change-Id: If13f886acdc7d8e89b115306934d9f7297067cf7
Reviewed-on: https://chromium-review.googlesource.com/740299
Reviewed-by: Valery Arkhangorodsky <varkha@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512204}
[modify] https://crrev.com/7e6f2699b135ca4b2f591275b84da32724dbc1aa/ash/wm/splitview/split_view_overview_overlay.cc

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment