New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778404 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 703263



Sign in to add a comment

LayerTreeHostFreesWorkerContextResourcesOnZeroMemoryLimitSynchronous.RunSingleThread_DelegatingRenderer flake

Project Member Reported by vmp...@chromium.org, Oct 25 2017

Issue description

This test just crashed on me, but it seems to be flaky since it works most of the time?

[ RUN      ] LayerTreeHostFreesWorkerContextResourcesOnZeroMemoryLimitSynchronous.RunSingleThread_DelegatingRenderer
[30571:30571:1025/143131.031214:18839067320340:FATAL:single_thread_proxy.cc(783)] Check failed: false. 
#0 0x7f9c52a93ddd base::debug::StackTrace::StackTrace()
#1 0x7f9c52a9220c base::debug::StackTrace::StackTrace()
#2 0x7f9c52b18f9a logging::LogMessage::~LogMessage()
#3 0x7f9c551b8522 cc::SingleThreadProxy::ScheduledActionInvalidateLayerTreeFrameSink()
#4 0x7f9c54fd42d2 cc::Scheduler::ProcessScheduledActions()
#5 0x7f9c54fd8c9f cc::Scheduler::BeginImplFrame()
#6 0x7f9c54fd6f83 cc::Scheduler::BeginImplFrameSynchronous()
#7 0x7f9c54fd68f8 cc::Scheduler::OnBeginFrameDerivedImpl()
#8 0x7f9c54c5cd6f viz::BeginFrameObserverBase::OnBeginFrame()
#9 0x7f9c54c66b65 viz::ExternalBeginFrameSource::OnBeginFrame()
#10 0x00000154118f viz::TestLayerTreeFrameSink::OnBeginFrame()
#11 0x7f9c5482fa56 viz::CompositorFrameSinkSupport::OnBeginFrame()
#12 0x7f9c54c64361 viz::DelayBasedBeginFrameSource::OnTimerTick()
#13 0x7f9c54c745b4 viz::DelayBasedTimeSource::OnTimerTick()

fsamuel@ do you mind triaging this? It seems that the test existed for a long time, so maybe it's something to do with OnBeginFrame stuff?

 

Comment 1 by danakj@chromium.org, Nov 15 2017

Labels: -Pri-3 Pri-1

Comment 2 by danakj@chromium.org, Nov 15 2017

Blocking: 703263

Comment 3 by piman@chromium.org, Feb 26 2018

Labels: -Pri-1 Pri-2

Comment 4 by danakj@chromium.org, Apr 25 2018

Cc: fsam...@chromium.org
Owner: danakj@chromium.org
Status: Started (was: Assigned)
This shouldnt run in single thread mode, its a webview test.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5df53794ff8c4f1d757f7087e4c57fc0fbe5c0d

commit a5df53794ff8c4f1d757f7087e4c57fc0fbe5c0d
Author: danakj <danakj@chromium.org>
Date: Thu Apr 26 18:36:39 2018

Remove flaky webview-only cc_unittest that shouldnt run single-thread

LayerTreeHostFreesWorkerContextResourcesOnZeroMemoryLimitSynchronous
test was set to run with SINGLE_AND_MULTI_THREAD_TEST_F but since it
is testing webview-only things, this caused DCHECKs to fail, in single-
threaded compositor code that does not expect to be called. Disable
the single-threaded version of the test, as WebView only uses/supports
multi-threaded cc.

R=enne@chromium.org

Bug:  778404 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie4076509ed550977acd61f1958165636e6265122
Reviewed-on: https://chromium-review.googlesource.com/1028186
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554096}
[modify] https://crrev.com/a5df53794ff8c4f1d757f7087e4c57fc0fbe5c0d/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/a5df53794ff8c4f1d757f7087e4c57fc0fbe5c0d/cc/trees/single_thread_proxy.cc

Comment 6 by danakj@chromium.org, Apr 26 2018

Status: Fixed (was: Started)

Sign in to add a comment