Checkbins step is failing on win x64 |
||||
Issue descriptionhttps://uberchromegw.corp.google.com/i/chromium/builders/Win%20x64/builds/15886 Checking C:\b\c\b\win_x64_archive\src\out\Release_x64\crashpad_util_test_process_info_test_child.exe ImageBase (0x78000000 < 4GB)... FAIL
,
Oct 25 2017
,
Oct 25 2017
https://chromium-review.googlesource.com/#/c/chromium/src/+/738512 -- if anyone doesn't want this new binary skipped, shout soon.
,
Oct 25 2017
Yes, that's fine. You could also filter matching "_test" or something.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efdf00827d5c11dee45528eba0199b20bea6ce32 commit efdf00827d5c11dee45528eba0199b20bea6ce32 Author: Nico Weber <thakis@chromium.org> Date: Wed Oct 25 21:51:34 2017 Let checkbins ignore crashpad_util_test_process_info_test_child.exe The binary intentionally sets an ImageBase < 4GB, and it's a test binary anyhow. Bug: 778398 Change-Id: Ia546728b3bcb5a4c4d1c5f04310ac06795e72c27 Reviewed-on: https://chromium-review.googlesource.com/738512 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#511601} [modify] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/tools/checkbins/checkbins.py
,
Oct 26 2017
cycled green |
||||
►
Sign in to add a comment |
||||
Comment 1 by thakis@chromium.org
, Oct 25 2017