New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778398 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 777924



Sign in to add a comment

Checkbins step is failing on win x64

Project Member Reported by pdr@chromium.org, Oct 25 2017

Issue description

https://uberchromegw.corp.google.com/i/chromium/builders/Win%20x64/builds/15886

Checking C:\b\c\b\win_x64_archive\src\out\Release_x64\crashpad_util_test_process_info_test_child.exe ImageBase (0x78000000 < 4GB)... FAIL 
 

Comment 1 by thakis@chromium.org, Oct 25 2017

Cc: mark@chromium.org jsc...@chromium.org grt@chromium.org cpu@chromium.org scottmg@chromium.org
https://chromium.googlesource.com/chromium/src/+blame/35ba756375d8cc60102cd9b76815d64070fa809e/tools/checkbins/checkbins.py#94 checks that ImageBase is > 4Gb for ASLR reasons.

crashpad intentionally wants that low ImageBase for unit testing purposes: https://cs.chromium.org/chromium/src/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn?sq=package:chromium&l=447

Does checkbins have a "ignore this file" mode?

Aha, there's EXCLUDED_FILES  early in the file, with this comment:

# Please do not add your file here without confirming that it indeed doesn't
# require /NXCOMPAT and /DYNAMICBASE.  Contact cpu@chromium.org or your local
# Windows guru for advice.


cpu, can I add my file?

cc'ing some other Windows gurus in case cpu is busy...

Comment 2 by thakis@chromium.org, Oct 25 2017

Blocking: 777924

Comment 3 by thakis@chromium.org, Oct 25 2017

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/#/c/chromium/src/+/738512 -- if anyone doesn't want this new binary skipped, shout soon.
Yes, that's fine. You could also filter matching "_test" or something.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efdf00827d5c11dee45528eba0199b20bea6ce32

commit efdf00827d5c11dee45528eba0199b20bea6ce32
Author: Nico Weber <thakis@chromium.org>
Date: Wed Oct 25 21:51:34 2017

Let checkbins ignore crashpad_util_test_process_info_test_child.exe

The binary intentionally sets an ImageBase < 4GB, and it's a test binary
anyhow.

Bug:  778398 
Change-Id: Ia546728b3bcb5a4c4d1c5f04310ac06795e72c27
Reviewed-on: https://chromium-review.googlesource.com/738512
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511601}
[modify] https://crrev.com/efdf00827d5c11dee45528eba0199b20bea6ce32/tools/checkbins/checkbins.py

Comment 6 by thakis@chromium.org, Oct 26 2017

Status: Fixed (was: Started)
cycled green

Sign in to add a comment