Ensure that both IPH Bubbles are presented using the Tracker's onInitialized method. |
|||
Issue descriptionCurrently, in BVC's presentBubblesIfEligible, only the New Tab Bubble is presented using the engagement tracker's ...OnInitialized method. This method ensures that if a request occurs before the tracker is initialized, the request is queued for when the tracker is ready. The second bubble should also probably use the ...OnInitialized method. This bug tracks the investigation to verify that this is the case, and the change itself.
,
Nov 2 2017
Right
,
Dec 5 2017
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/566351921fe8b2aa6b1a02d643d3cdfca890c8bb commit 566351921fe8b2aa6b1a02d643d3cdfca890c8bb Author: Gregory Chatzinoff <gchatz@chromium.org> Date: Wed Dec 06 02:11:26 2017 Defer Incognito Bubble Presentation. Ensure that the Incognito Bubble presentation is deferred until after the feature engagement tracker is initialized, just as the New Tab Bubble is deferred. Bug: 778395 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I33c86953665211a7cfafc8e27349892d01e43b80 Reviewed-on: https://chromium-review.googlesource.com/809848 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521949} [modify] https://crrev.com/566351921fe8b2aa6b1a02d643d3cdfca890c8bb/ios/chrome/browser/ui/browser_view_controller.mm
,
Dec 6 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ghendel@chromium.org
, Nov 2 2017