New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778384 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add filtering for survey

Project Member Reported by danielpark@chromium.org, Oct 25 2017

Issue description

Add filtering to survey system as discussed in design doc.

 
Owner: danielpark@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eec2194c990e524c44ce252b44c4e006762639ce

commit eec2194c990e524c44ce252b44c4e006762639ce
Author: Daniel Park <danielpark@chromium.org>
Date: Tue Nov 28 21:11:57 2017

[Chrome Home Survey] Adds client-side filtering

-Reorders order for doesUserQualify
-Adds filtering methods
-Adds tests for filtering methods
-Adds logging for when the last time the random # gen. was rolled
-Adds Chrome Home Force Survey check to doesUserQualify to allow for
  testing of other survey qualifications

Filtering method:
-Gets the max number from the finch config
-Rolls a random number up from 0 (inclusive) to that number (exclusive)
-If the random number = 0, process continues for user
-Else stop


Bug:  778384 
Change-Id: Ie7063724614c98121e0e93c1a4b091557635015a
Reviewed-on: https://chromium-review.googlesource.com/741867
Commit-Queue: Daniel Park <danielpark@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519836}
[modify] https://crrev.com/eec2194c990e524c44ce252b44c4e006762639ce/chrome/android/java/src/org/chromium/chrome/browser/survey/ChromeHomeSurveyController.java
[modify] https://crrev.com/eec2194c990e524c44ce252b44c4e006762639ce/chrome/android/junit/src/org/chromium/chrome/browser/survey/ChromeHomeSurveyControllerTest.java

Status: Fixed (was: Started)

Sign in to add a comment