We should stop rendering when screen is off. |
||||
Issue descriptionWhen I was investigating the vsync provider on chromebook (chell), I found we are continue calling SwapBuffers for the login screen when screen is off (due to no user input for a while). I didn't test chrome after login, but I think it may have the same issue. For better battery performance, should we stop doing it? See below attached patch which I used for the test. When the screen is off, methods GpuBrowserCompositorOutputSurface::SwapBuffers(), GpuBrowserCompositorOutputSurface::OnGpuSwapBuffersCompleted() and DrmVSyncProvider::GetVSyncParameters() are being called continuously. Method GpuBrowserCompositorOutputSurface::OnVSyncParametersUpdated() is called at all, probably it is because the vsync signal is disabled.
,
Oct 25 2017
If we stop rendering, doesn't that mean that when the user interacts with the machine again, we'll see a flash of out-of-date contents?
,
Oct 25 2017
Naively, we could just render one frame before we turn the screen back on? IIRC we already do something like this for monitor plug/resolution changes.
,
Oct 27 2017
Thanks this is an interesting find. => vmiura for prioritization.
,
Oct 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by danakj@chromium.org
, Oct 25 2017