New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 778374 link

Starred by 2 users
Status: Fixed
Owner:
█ acondor@chromium.org
Last visit > 30 days ago
Closed: Sep 18
Cc:
█ vollick@chromium.org
cjgrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR

Blocked on:
issue 767282


Sign in to add a comment

VR: Add tests for vr_shell_gl functionality

Project Member Reported by mthiesse@chromium.org, Oct 25 2017 
vr_shell_gl is a monolithic Android-only class that needs to be split up, make cross-platform, and testable.

Some of the things that need testing:
-Redrawing logic
-Frame timing
-Mode switching
-Update/Rendering sequencing
etc.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f6c980434d478741a819d0cc1372ae0b1f66d59

commit 3f6c980434d478741a819d0cc1372ae0b1f66d59
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Nov 06 19:40:50 2017

[vr] Factor ContentInputDelegate out of VrShellGl

With this change, the ContentInputDelegate interface has been converted
into a class and its functionality moved from VrShellGl into that class
implementation.

Bug:  778374 
Change-Id: I0bf43d568d4ef2c1c986201aa890a947ae1da0ab
Reviewed-on: https://chromium-review.googlesource.com/753436
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514209}
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/android/vr_shell/gl_browser_interface.h
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/android/vr_shell/vr_controller.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/android/vr_shell/vr_controller.h
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/android/vr_shell/vr_web_contents_observer.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/content_input_delegate.h
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/elements/url_bar_texture.h
[add] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/macros.h
[add] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/platform_controller.h
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/test/mock_content_input_delegate.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/ui.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/ui.h
[delete] https://crrev.com/985e9443e23940d15fcad2accfab741156239a8c/chrome/browser/vr/ui_interface.h
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/3f6c980434d478741a819d0cc1372ae0b1f66d59/chrome/browser/vr/ui_scene_manager.h

Comment 2 by vollick@chromium.org, Nov 7 2017

Blockedon: 767282

Comment 3 by btebbs@chromium.org, Jul 4

Components: Internals>XR

Comment 4 by btebbs@chromium.org, Jul 12

Components: -Internals>XR Internals>XR>VR

Comment 5 by ddorwin@chromium.org, Jul 16

Owner: acondor@chromium.org
Status: Assigned (was: Available)
Assigning to acondor who owns the refactoring bug.

Comment 6 by btebbs@chromium.org, Jul 16

Labels: VR-Desktop-UI

Comment 7 by efoo@chromium.org, Aug 7

Components: Internals>XR
Removing Internals>VR component and remapping to Internals>XR

Comment 8 by efoo@chromium.org, Aug 7

Components: -Internals>VR
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4836b79eb910af73f02de607abb0b6ab0ad5b544

commit 4836b79eb910af73f02de607abb0b6ab0ad5b544
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Thu Sep 13 18:52:27 2018

VR: Add unit tests for BrowserRenderer

Bug:  778374 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia903ecd1f36426db67b5f229c124aacf0a953cc4
Reviewed-on: https://chromium-review.googlesource.com/1196905
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591091}
[modify] https://crrev.com/4836b79eb910af73f02de607abb0b6ab0ad5b544/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/4836b79eb910af73f02de607abb0b6ab0ad5b544/chrome/browser/vr/base_graphics_delegate.cc
[modify] https://crrev.com/4836b79eb910af73f02de607abb0b6ab0ad5b544/chrome/browser/vr/base_graphics_delegate.h
[add] https://crrev.com/4836b79eb910af73f02de607abb0b6ab0ad5b544/chrome/browser/vr/browser_renderer_unittest.cc
[modify] https://crrev.com/4836b79eb910af73f02de607abb0b6ab0ad5b544/chrome/browser/vr/graphics_delegate.h
[modify] https://crrev.com/4836b79eb910af73f02de607abb0b6ab0ad5b544/chrome/browser/vr/scheduler_delegate.h
[modify] https://crrev.com/4836b79eb910af73f02de607abb0b6ab0ad5b544/chrome/browser/vr/ui.cc
[modify] https://crrev.com/4836b79eb910af73f02de607abb0b6ab0ad5b544/chrome/browser/vr/ui.h
[modify] https://crrev.com/4836b79eb910af73f02de607abb0b6ab0ad5b544/chrome/browser/vr/ui_interface.h
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/642bae683a756cdfb28ff59749f5585a26ca1dd2

commit 642bae683a756cdfb28ff59749f5585a26ca1dd2
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Tue Sep 18 22:08:19 2018

Add unit tests for the BaseSchedulerDelegate

Bug:  778374 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I85cb90ae37a502fc86a0a28c22b1011ae66a6ed7
Reviewed-on: https://chromium-review.googlesource.com/1220571
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592220}
[modify] https://crrev.com/642bae683a756cdfb28ff59749f5585a26ca1dd2/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/642bae683a756cdfb28ff59749f5585a26ca1dd2/chrome/browser/vr/base_scheduler_delegate_unittest.cc
[modify] https://crrev.com/642bae683a756cdfb28ff59749f5585a26ca1dd2/chrome/browser/vr/scheduler_delegate.h

Comment 11 by acondor@chromium.org, Sep 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment