New issue
Advanced search Search tips

Issue 778373 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Enterprise policy for Chrome's ad blocker and stronger pop-up blocker

Project Member Reported by shivanisha@chromium.org, Oct 25 2017

Issue description

Create two enterprise policies for Chrome's ad blocker and stronger pop-up blocker:
- for Better Ads Standard
- for Abusive Enforcement
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b937f213420b0f78e624c9db176d145eeffb0944

commit b937f213420b0f78e624c9db176d145eeffb0944
Author: Min Qin <qinmin@chromium.org>
Date: Wed Oct 25 20:25:39 2017

Disable 2 payment browertests on Mojo_Linux

TBR=rouslan@chromium.org
BUG= 778373 

Change-Id: I130c217355cf833194dd96fdba675730d002bd5c
Reviewed-on: https://chromium-review.googlesource.com/737958
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511561}
[modify] https://crrev.com/b937f213420b0f78e624c9db176d145eeffb0944/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Description: Show this description
Summary: Enterprise policy for Chrome's ad blocker and stronger pop-up blocker (was: Enterprise policy for Chromenolia)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3434513882242b492e5ffb4fa8d8c80f5acc554a

commit 3434513882242b492e5ffb4fa8d8c80f5acc554a
Author: Shivani Sharma <shivanisha@chromium.org>
Date: Thu Dec 07 20:18:08 2017

Enterprise policy for abusive experiences intervention

Introduces a new preference abusive_experience_intervention_enforce
for abusive experiences intervention and a policy
abusive_experience_intervention_enforce that maps to that
preference. Whether or not the intervention should be applied is now a
function of the feature as well as the policy, as follows:
- If feature is disabled, do not apply.
- If feature is enabled and policy is not set, apply.
- If feature is enabled and policy is set, apply or not based on the
policy value.

TEST=browser_tests --gtest_filter=
SafeBrowsingTriggeredPopupBlockerBrowserTest.*EnterprisePolicy*

Bug:  778373 
Change-Id: I7d3867a13762f4fe824af866d48fc95e4e33d767
Reviewed-on: https://chromium-review.googlesource.com/794211
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522525}
[modify] https://crrev.com/3434513882242b492e5ffb4fa8d8c80f5acc554a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/3434513882242b492e5ffb4fa8d8c80f5acc554a/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/3434513882242b492e5ffb4fa8d8c80f5acc554a/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.cc
[modify] https://crrev.com/3434513882242b492e5ffb4fa8d8c80f5acc554a/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.h
[modify] https://crrev.com/3434513882242b492e5ffb4fa8d8c80f5acc554a/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_browsertest.cc
[modify] https://crrev.com/3434513882242b492e5ffb4fa8d8c80f5acc554a/chrome/common/pref_names.cc
[modify] https://crrev.com/3434513882242b492e5ffb4fa8d8c80f5acc554a/chrome/common/pref_names.h
[modify] https://crrev.com/3434513882242b492e5ffb4fa8d8c80f5acc554a/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/3434513882242b492e5ffb4fa8d8c80f5acc554a/components/policy/resources/policy_templates.json
[modify] https://crrev.com/3434513882242b492e5ffb4fa8d8c80f5acc554a/tools/metrics/histograms/enums.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b309fb0b2720075acd0421a3592024a95765c44

commit 1b309fb0b2720075acd0421a3592024a95765c44
Author: Shivani Sharma <shivanisha@chromium.org>
Date: Fri Dec 22 14:49:46 2017

Enterprise policy for Ads for Better Ads Standard violating sites

Introduces a new enterprise policy AdsSettingForIntrusiveAdsSites that
maps to the content setting for Ads. The policy value is reflected in
the content settings UI and the content settings Ads UI is not editable
by the user. The setting can be changed without without restarting the
browser and its new value will be reflected in the content settings UI
and will take effect in any subsequently opened tab.

DrivenByEnterprisePolicy

TEST: browser_tests --gtest_filter=SubresourceFilterSettingsBrowserTest.
Bug:  778373 
Change-Id: I04e8b6ebf93193c66980e483e785a11dac94831f
Reviewed-on: https://chromium-review.googlesource.com/737865
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525990}
[modify] https://crrev.com/1b309fb0b2720075acd0421a3592024a95765c44/chrome/browser/content_settings/host_content_settings_map_unittest.cc
[modify] https://crrev.com/1b309fb0b2720075acd0421a3592024a95765c44/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/1b309fb0b2720075acd0421a3592024a95765c44/chrome/browser/subresource_filter/subresource_filter_settings_browsertest.cc
[modify] https://crrev.com/1b309fb0b2720075acd0421a3592024a95765c44/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/1b309fb0b2720075acd0421a3592024a95765c44/components/content_settings/core/browser/content_settings_policy_provider.cc
[modify] https://crrev.com/1b309fb0b2720075acd0421a3592024a95765c44/components/content_settings/core/common/pref_names.cc
[modify] https://crrev.com/1b309fb0b2720075acd0421a3592024a95765c44/components/content_settings/core/common/pref_names.h
[modify] https://crrev.com/1b309fb0b2720075acd0421a3592024a95765c44/components/policy/resources/policy_templates.json
[modify] https://crrev.com/1b309fb0b2720075acd0421a3592024a95765c44/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)

Sign in to add a comment