New issue
Advanced search Search tips

Issue 778351 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 778289



Sign in to add a comment

Unify pointercancel handling in PointerEventManager

Project Member Reported by nzolghadr@chromium.org, Oct 25 2017

Issue description

After adding pointercancel for mouse drag case now we have two paths for sending pointercancel. One for mouse and one for touch scrolling. We need to first unify these two.
 
Blocking: 778289

Comment 2 by mustaq@chromium.org, Oct 25 2017

Summary: Unify pointercancel handling in PointerEventManager (was: Unify pointercancel paths)
Renamed the bug to clarify that we didn't mean the whole path from browser to PointerEventManager.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48b81fca948ed378854e65af20bbfadda1d9548f

commit 48b81fca948ed378854e65af20bbfadda1d9548f
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Wed Nov 01 20:12:11 2017

Unify the pointer cancel path in PEManager

Before this CL we had two different paths
for creating pointercancels. One for mouse
pointercancels and one for touch/pen cancels.
This LC refactor the code for these two paths.

Bug:  778351 
Change-Id: Ie498c5afb2e3aee7938e51db33ea8de7cb7323dc
Reviewed-on: https://chromium-review.googlesource.com/740144
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513238}
[modify] https://crrev.com/48b81fca948ed378854e65af20bbfadda1d9548f/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/48b81fca948ed378854e65af20bbfadda1d9548f/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/48b81fca948ed378854e65af20bbfadda1d9548f/third_party/WebKit/Source/core/events/PointerEventFactory.h
[modify] https://crrev.com/48b81fca948ed378854e65af20bbfadda1d9548f/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
[modify] https://crrev.com/48b81fca948ed378854e65af20bbfadda1d9548f/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/48b81fca948ed378854e65af20bbfadda1d9548f/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/48b81fca948ed378854e65af20bbfadda1d9548f/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/48b81fca948ed378854e65af20bbfadda1d9548f/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/48b81fca948ed378854e65af20bbfadda1d9548f/third_party/WebKit/Source/core/input/PointerEventManager.h
[add] https://crrev.com/48b81fca948ed378854e65af20bbfadda1d9548f/third_party/WebKit/Source/core/input/PointerEventManagerTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment