We agreed that exo will stay in ash process in mustash, so we no longer need WMHelper classes. Please let me know if you have any concern about removing it. Otherwise, I'll work on it next week.
It's probably better to 1) remove WMHelperAsh/Mus but keep WMHelper for DragDropObserver, 2) to simplify the observer addition/removal. https://chromium-review.googlesource.com/c/chromium/src/+/754090/8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6 commit e73f470cd8a3b7b32d0cb2497f10e3c7511431a6 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Nov 08 16:22:34 2017 Consolicate WMHelperAsh and WMHelper, remove WMHelperMus I'll remove accessors in separate CL(s). Bug: 778331 Change-Id: Ia13d4eb195c8ebcf96986c8474566b332a065d49 Reviewed-on: https://chromium-review.googlesource.com/754090 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#514852} [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/ash/wayland/wayland_server_controller.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/chrome/browser/exo_parts.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/arc/ime/arc_ime_service.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/arc/ime/arc_ime_service.h [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/BUILD.gn [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/gaming_seat.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/gaming_seat.h [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/keyboard.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/keyboard.h [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/pointer.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/pointer.h [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/shell_surface.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/shell_surface.h [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/test/exo_test_base.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/wayland/BUILD.gn [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/wayland/clients/test/wayland_client_test.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/wayland/server.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/wm_helper.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/components/exo/wm_helper.h [delete] https://crrev.com/28922ba386cbc4d88455aee948cc8bde10503ed3/components/exo/wm_helper_ash.cc [delete] https://crrev.com/28922ba386cbc4d88455aee948cc8bde10503ed3/components/exo/wm_helper_ash.h [delete] https://crrev.com/28922ba386cbc4d88455aee948cc8bde10503ed3/components/exo/wm_helper_mus.cc [delete] https://crrev.com/28922ba386cbc4d88455aee948cc8bde10503ed3/components/exo/wm_helper_mus.h [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/ui/arc/notification/arc_notification_content_view_unittest.cc [modify] https://crrev.com/e73f470cd8a3b7b32d0cb2497f10e3c7511431a6/ui/compositor/compositor_vsync_manager.h
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!
Comment 1 by osh...@chromium.org
, Oct 25 2017