New issue
Advanced search Search tips

Issue 778309 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 751321



Sign in to add a comment

Strip unneeded paths from the slow-report trace produced by memlog

Project Member Reported by etienneb@chromium.org, Oct 25 2017

Issue description

Remove strings that may contains user information from reported trace.

Some path may contains username if manually installed.
These paths are used to detect how to symbolize a trace, thus a canonical path is enough.

The command-line in the metadata may also contains information passed as a flag.

Check that there is no other strings to be stripped.
 
Blocking: 751321
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5768afb3d613ccc54cdbad17fa1e780b5cab38dd

commit 5768afb3d613ccc54cdbad17fa1e780b5cab38dd
Author: Etienne Bergeron <etienneb@chromium.org>
Date: Tue Oct 31 21:32:01 2017

Strip unneeded paths from the slow-report trace produced by memlog.

This CL is adding a ExportParam flags to turn on/off stripping strings
from memory dumps automatically uploaded by memlog.

R=erikchen@chromium.org

Bug:  778309 
Change-Id: I0074d4158f88dd3fd34474b10c432e76e23f30ad
Reviewed-on: https://chromium-review.googlesource.com/742286
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512957}
[modify] https://crrev.com/5768afb3d613ccc54cdbad17fa1e780b5cab38dd/chrome/browser/profiling_host/profiling_process_host.h
[modify] https://crrev.com/5768afb3d613ccc54cdbad17fa1e780b5cab38dd/chrome/profiling/json_exporter.cc
[modify] https://crrev.com/5768afb3d613ccc54cdbad17fa1e780b5cab38dd/chrome/profiling/json_exporter.h
[modify] https://crrev.com/5768afb3d613ccc54cdbad17fa1e780b5cab38dd/chrome/profiling/memlog_connection_manager.cc
[modify] https://crrev.com/5768afb3d613ccc54cdbad17fa1e780b5cab38dd/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.cc
[modify] https://crrev.com/5768afb3d613ccc54cdbad17fa1e780b5cab38dd/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.h

Status: Fixed (was: Assigned)

Sign in to add a comment