New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778300 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Update IANA timezone database / zonefile to 2017c

Project Member Reported by js...@chromium.org, Oct 25 2017

Issue description

2017 has been rather quiet in terms of TZDB update frequency, but 2017c was released a couple of days ago. [1]  

For non-Chrome OS, I'll update the ICU tzdb files. 

For Chrome OS, zonefiles have to be updated. (sys-libs/timezone-data)

The upstream does not yet have 2017c, though. 

https://packages.gentoo.org/packages/sys-libs/timezone-data


http://mm.icann.org/pipermail/tz-announce/2017-October/000047.html 

 

Comment 1 by js...@chromium.org, Oct 25 2017

Labels: -Pri-3 M-63 Pri-2
Some countries decided to change the timezone almost the last moment. At least, this has to be in M63 if not M62. 

Comment 2 by js...@chromium.org, Oct 25 2017

Description: Show this description

Comment 3 by js...@chromium.org, Oct 25 2017

Mike, can you bump tzdb to 2017c in the Gentoo upstream ? 
 ( https://packages.gentoo.org/packages/sys-libs/timezone-data )

Comment 4 by js...@chromium.org, Oct 25 2017

Test:

In JavaScript console, run the 4 lines below (starting with '>') to get the results shown below. Nov 1st, Sudan is switching from UTC+3 to UTC+2
( Africa/Khartoum ), but South Sudan (Africa/Juba) will stay in UTC+3. 


> (new Date(Date.UTC(2017,9, 31, 12))).toLocaleString("en", {'timeZone': 'Africa/Khartoum'})
"10/31/2017, 3:00:00 PM"

> (new Date(Date.UTC(2017,10, 1, 12))).toLocaleString("en", {'timeZone': 'Africa/Khartoum'})
"11/1/2017, 2:00:00 PM"

> (new Date(Date.UTC(2017,9, 31, 12))).toLocaleString("en", {'timeZone': 'Africa/Juba'})
"10/31/2017, 3:00:00 PM"

> (new Date(Date.UTC(2017,10, 1, 12))).toLocaleString("en", {'timeZone': 'Africa/Juba'})
"11/1/2017, 3:00:00 PM"

Comment 5 by js...@chromium.org, Oct 26 2017

Description: Show this description

Comment 6 by pkl@chromium.org, Oct 30 2017

Components: Internals

Comment 7 by js...@chromium.org, Nov 3 2017

> Mike, can you bump tzdb to 2017c in the Gentoo upstream ? 
> ( https://packages.gentoo.org/packages/sys-libs/timezone-data )

I filed https://bugs.gentoo.org/636464 


Project Member

Comment 9 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23d0b048bf7e4974eb6870c99a3639015b654b2d

commit 23d0b048bf7e4974eb6870c99a3639015b654b2d
Author: Jungshik Shin <jshin@chromium.org>
Date: Fri Nov 03 23:45:22 2017

Roll ICU to 4b5a7240d2

It has just one change to update IANA tzdb to 2017c
 ( https://chromium-review.googlesource.com/738833 ).

TBR=mark@chromium.org

Bug:  chromium:778300 
Test: See bug commment 4
Change-Id: Ia149560be38653112dc7a650f1d9a2fd8927a722
Reviewed-on: https://chromium-review.googlesource.com/754053
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513962}
[modify] https://crrev.com/23d0b048bf7e4974eb6870c99a3639015b654b2d/DEPS

 > filed https://bugs.gentoo.org/636464 

Upstream fixed it. I'll update sys-libs/timezone-data per 
https://sites.google.com/a/chromium.org/dev/chromium-os/gentoo-package-upgrade-process .


Upstream used EAPI=6, but our portage is still EAPI=5. Just setting EAPI to 5 with the upstream ebuild does not work because it uses EAPI6-only features (e.g. eapply). 

Mike, should I add a forked version to chromiumos-overlay ?  


Test for CrOS:

After installing timezone-data-2017c on a device,  run the following. The former should be 1 hour ahead of the latter (in Nov 2017). 

$ TZ=Africa/Juba date
$ TZ=Africa/Khartoum date
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/0dc5584c822949a950e54dce5ac705df35faa170

commit 0dc5584c822949a950e54dce5ac705df35faa170
Author: Jungshik Shin <jshin@chromium.org>
Date: Thu Nov 09 03:48:56 2017

Update IANA timezone data to 2017c

Modify the upstream 2017c ebuild slightly to get it
to work with EAPI=5. The only change other than setting
EAPI to 5 is to replace 'eapply' with 'epatch'.

BUG= chromium:778300 
TEST=See bug comment 12

Change-Id: Iecc3898dd059bd7d16f1640ee35ec404072988a0
Reviewed-on: https://chromium-review.googlesource.com/757993
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/0dc5584c822949a950e54dce5ac705df35faa170/sys-libs/timezone-data/Manifest
[rename] https://crrev.com/0dc5584c822949a950e54dce5ac705df35faa170/sys-libs/timezone-data/files/timezone-data-2017c-makefile.patch
[rename] https://crrev.com/0dc5584c822949a950e54dce5ac705df35faa170/sys-libs/timezone-data/timezone-data-2017c.ebuild

Comment 14 by js...@chromium.org, Nov 13 2017

Labels: Merge-Request-63
Status: Fixed (was: Assigned)
Merge Request to 63 (baked in canary builds )

1. All platforms: ICU DEPS roll (comment 9). Actual change in comment 8.
2. CrOS: Change in comment 13. 

This is a routine timezone database update. Although there are not many users, some regions have timezone changes that went into effect in late October/early November. 
Project Member

Comment 15 by sheriffbot@chromium.org, Nov 13 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: Less than 18 days to go before AppStore submit on M63
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 16 Deleted

Cc: gkihumba@chromium.org
Approving merge or all non chrome os platforms per comment #14 to M63 branch 3239. Please merge ASAP so we can take it in for this week beta release. Thank you.

gkihumba@ for Chrome OS change approval.
Ok to merge cros
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 14 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/f45b5e6f55eea575f579a7462a2441c56573dcb1

commit f45b5e6f55eea575f579a7462a2441c56573dcb1
Author: Jungshik Shin <jshin@chromium.org>
Date: Tue Nov 14 05:48:23 2017

Update IANA timezone data to 2017c

Modify the upstream 2017c ebuild slightly to get it
to work with EAPI=5. The only change other than setting
EAPI to 5 is to replace 'eapply' with 'epatch'.

BUG= chromium:778300 
TEST=See bug comment 12

Change-Id: Iecc3898dd059bd7d16f1640ee35ec404072988a0
Previous-Reviewed-on: https://chromium-review.googlesource.com/757993
(cherry picked from commit b2eb4d0f85799f0fa063c5cca8e3deb32c765187)
Reviewed-on: https://chromium-review.googlesource.com/767968
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>

[modify] https://crrev.com/f45b5e6f55eea575f579a7462a2441c56573dcb1/sys-libs/timezone-data/Manifest
[rename] https://crrev.com/f45b5e6f55eea575f579a7462a2441c56573dcb1/sys-libs/timezone-data/files/timezone-data-2017c-makefile.patch
[rename] https://crrev.com/f45b5e6f55eea575f579a7462a2441c56573dcb1/sys-libs/timezone-data/timezone-data-2017c.ebuild

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/e723936372c98a79f5f5693cd0d37822cd56bdee

commit e723936372c98a79f5f5693cd0d37822cd56bdee
Author: Jungshik Shin <jungshik@google.com>
Date: Tue Nov 14 18:30:02 2017

Comment 21 by js...@chromium.org, Nov 14 2017

Labels: -Merge-Approved-63 merge-merged-3239

Sign in to add a comment