To continue the refactoring path we had and also to help the oopif team for targeting the events we would like to completely get rid of the WebTouchEvent in blink and make blink to only expect WebPointerEvent instead of WebTouchEvent.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a274b64e9af0c1a8bc9cb715627f47495507a04a commit a274b64e9af0c1a8bc9cb715627f47495507a04a Author: Navid Zolghadr <nzolghadr@chromium.org> Date: Fri Jan 05 18:48:05 2018 Remove HandleTouchEvents from internal Blink API Remove HandleTouchEvents from EventHandler and other internal classes up to WebWidget. It also update the corresponding tests. Bug: 778289 Change-Id: I5f495c04f52445a1286fc5e4e4c4c93d6c6ce80d Reviewed-on: https://chromium-review.googlesource.com/826867 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#527335} [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/events/WebInputEventConversion.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/events/WebInputEventConversion.h [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/events/WebInputEventConversionTest.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/exported/WebPagePopupImpl.h [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/exported/WebViewImpl.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/exported/WebViewImpl.h [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/input/EventHandler.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/input/EventHandler.h [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/input/MouseEventManager.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/input/PointerEventManagerTest.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/input/TouchEventManagerTest.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.h [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/core/page/PageWidgetDelegate.h [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/platform/WebPointerEvent.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/Source/platform/exported/WebCoalescedInputEvent.cpp [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/public/platform/WebCoalescedInputEvent.h [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/public/platform/WebPointerEvent.h [modify] https://crrev.com/a274b64e9af0c1a8bc9cb715627f47495507a04a/third_party/WebKit/public/platform/WebPointerProperties.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e commit 24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e Author: Navid Zolghadr <nzolghadr@chromium.org> Date: Wed Jan 24 20:58:04 2018 Remove Handling of WebTouchEvents from WebWidget Bug: 778289 Change-Id: I65a3710f7b5728c44d714d4a43405ad78720edb2 Reviewed-on: https://chromium-review.googlesource.com/862258 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#531680} [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/content/renderer/input/render_widget_input_handler.cc [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/content/renderer/input/render_widget_input_handler.h [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/content/renderer/pepper/event_conversion.cc [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/content/renderer/pepper/pepper_plugin_instance_impl.cc [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/content/renderer/render_widget_unittest.cc [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/content/shell/test_runner/event_sender.cc [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/events/WebInputEventConversion.cpp [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/events/WebInputEventConversion.h [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/exported/WebPagePopupImpl.h [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/exported/WebViewImpl.cpp [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/exported/WebViewImpl.h [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/frame/WebViewFrameWidget.cpp [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/frame/WebViewFrameWidget.h [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/input/TouchActionTest.cpp [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/Source/core/page/PageWidgetDelegate.h [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/public/web/WebView.h [modify] https://crrev.com/24ff17d22722f4e7f1bd3c7fdd127ede4e6c0a1e/third_party/WebKit/public/web/WebWidget.h
Finally done :)
Comment 1 by nzolghadr@chromium.org
, Oct 25 2017