New issue
Advanced search Search tips

Issue 778276 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 800880

Blocking:
issue 778275



Sign in to add a comment

Chrome Android: implement media intent handler

Project Member Reported by mlamouri@chromium.org, Oct 25 2017

Issue description

Have Chrome Android handle media playback by registering the approriate intent.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c6a0c2dbf24c47f842dea4cf0745d6a86c2cd78

commit 0c6a0c2dbf24c47f842dea4cf0745d6a86c2cd78
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Dec 19 18:53:33 2017

Extract getMediaViewerIntent logic from DownloadUtils into MediaUtils

This CL creates a new MediaViewerUtils class and adds the logic for
creating a media-viewing CustomTabActivity Intent, removing it from
DownloadUtils. This will make sharing that logic with the upcoming
MediaViewerActivity cleaner.

Bug:  778276 
Change-Id: Ie967e5600943558e08c26492e38831e6da7c153d
Reviewed-on: https://chromium-review.googlesource.com/821515
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525092}
[modify] https://crrev.com/0c6a0c2dbf24c47f842dea4cf0745d6a86c2cd78/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/0c6a0c2dbf24c47f842dea4cf0745d6a86c2cd78/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationFactory.java
[modify] https://crrev.com/0c6a0c2dbf24c47f842dea4cf0745d6a86c2cd78/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/0c6a0c2dbf24c47f842dea4cf0745d6a86c2cd78/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[add] https://crrev.com/0c6a0c2dbf24c47f842dea4cf0745d6a86c2cd78/chrome/android/java/src/org/chromium/chrome/browser/media/MediaViewerUtils.java
[modify] https://crrev.com/0c6a0c2dbf24c47f842dea4cf0745d6a86c2cd78/chrome/android/java_sources.gni
[modify] https://crrev.com/0c6a0c2dbf24c47f842dea4cf0745d6a86c2cd78/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java

Cc: mlamouri@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e3129e171cc2b67d534ec1d7430be464430150a

commit 7e3129e171cc2b67d534ec1d7430be464430150a
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Dec 21 17:37:41 2017

Propagate content URI permissions for CustomTabActivities

This CL propagates read permissions for content:// URIs in the
LaunchIntentDispatcher when launching CustomTabActivities. This is
necessary for the upcoming MediaViewerActivity, which will create a
CustomTabActivity to view media from a content:// URI.

Bug:  778276 
Change-Id: I8b62c1e8100ce7f865a20fc901bb8c166b04746c
Reviewed-on: https://chromium-review.googlesource.com/839820
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Ted Choc (OOO til 2018) <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525729}
[modify] https://crrev.com/7e3129e171cc2b67d534ec1d7430be464430150a/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e6018672258ac503842bf7e1f9d956696099c18

commit 8e6018672258ac503842bf7e1f9d956696099c18
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Jan 08 18:42:49 2018

Add param to getMediaViewerIntent to toggle Open With option

This CL adds a boolean param to MediaViewerUtils.getMediaViewerIntent
which when true adds an Open With option to the CustomTabActivity.
This is currently always given true, but will be false when called
from the upcoming MediaViewerActivity. This CL does not handle the
issue of hiding the three-dot menu that will be empty without Open
With.

Bug:  778276 
Change-Id: Ica68ab27ba1b78a49e084139ef8e265b07361700
Reviewed-on: https://chromium-review.googlesource.com/837650
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527685}
[modify] https://crrev.com/8e6018672258ac503842bf7e1f9d956696099c18/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/8e6018672258ac503842bf7e1f9d956696099c18/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/8e6018672258ac503842bf7e1f9d956696099c18/chrome/android/java/src/org/chromium/chrome/browser/media/MediaViewerUtils.java
[modify] https://crrev.com/8e6018672258ac503842bf7e1f9d956696099c18/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java

Blockedon: 800875
Blockedon: 800880
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a6cb12f705b4601ef716d4ef1df4b0d179e6167

commit 7a6cb12f705b4601ef716d4ef1df4b0d179e6167
Author: Tommy Steimel <steimel@chromium.org>
Date: Wed Jun 20 22:33:17 2018

Create disabled MediaLauncherActivity to listen for media view intents

This CL creates a MediaLauncherActivity class that handles media VIEW
Intents and opens them in a media-viewing CustomTabActivity. The
MediaLauncherActivity is added to the manifest but is disabled.

Bug:  778276 
Change-Id: I9111f446849722976c7e39c38f611ff3966cb9b7
Reviewed-on: https://chromium-review.googlesource.com/857324
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569052}
[modify] https://crrev.com/7a6cb12f705b4601ef716d4ef1df4b0d179e6167/chrome/android/java/AndroidManifest.xml
[add] https://crrev.com/7a6cb12f705b4601ef716d4ef1df4b0d179e6167/chrome/android/java/src/org/chromium/chrome/browser/media/MediaLauncherActivity.java
[modify] https://crrev.com/7a6cb12f705b4601ef716d4ef1df4b0d179e6167/chrome/android/java/src/org/chromium/chrome/browser/media/MediaViewerUtils.java
[modify] https://crrev.com/7a6cb12f705b4601ef716d4ef1df4b0d179e6167/chrome/android/java_sources.gni

Blockedon: -800875
Status: Fixed (was: Assigned)

Sign in to add a comment