New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778274 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add private key arg to deploy_chrome (like ssh's -i)

Project Member Reported by aelder@google.com, Oct 25 2017

Issue description

When working with test images where it's not desirable to use the publicly available test key, it should be easier to specify an alternative key to use when running `deploy_chrome`. 

 

Comment 1 by aelder@chromium.org, Oct 25 2017

Cc: vapier@chromium.org

Comment 2 by aelder@chromium.org, Oct 25 2017

Owner: aelder@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a2c548abeaad5b640ea755961f42b949a0efc0dd

commit a2c548abeaad5b640ea755961f42b949a0efc0dd
Author: Adrian Elder <aelder@chromium.org>
Date: Thu Nov 16 00:07:31 2017

deploy_chrome: Add --private_key option

This allows using deploy chrome on test devices that have an ssh key other than the publicly
available test key.

BUG= 778274 
TEST=Replaced test key on a CrOS device and successfully deployed.
Change-Id: I5bdb032e0ed621758fca83c9d9c0309d5764ba40
Reviewed-on: https://chromium-review.googlesource.com/737552
Commit-Ready: Adrian Elder <aelder@chromium.org>
Tested-by: Adrian Elder <aelder@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a2c548abeaad5b640ea755961f42b949a0efc0dd/scripts/deploy_chrome.py
[modify] https://crrev.com/a2c548abeaad5b640ea755961f42b949a0efc0dd/scripts/deploy_chrome_unittest.py

Comment 4 by aelder@chromium.org, Nov 20 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment