New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778271 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 667560



Sign in to add a comment

frame-model-instrumentation.html fail on Win 7 dbg

Project Member Reported by vasi...@chromium.org, Oct 25 2017

Issue description

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11745

Both http/tests/devtools/tracing/frame-model-instrumentation.html and virtual/mojo-loading/http/tests/devtools/tracing/frame-model-instrumentation.html fail with

CONSOLE MESSAGE: line 334: Internal watchdog triggered at 20 seconds. Test timed out.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd35a843845c1820d06082fd2edf780abcd442e6

commit fd35a843845c1820d06082fd2edf780abcd442e6
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Wed Oct 25 15:59:48 2017

Update expectations on frame-model-instrumentation.html. The test fails on Win.

TBR=chenwilliam@chromium.org

Bug:  778271 
Change-Id: Ic92566b7b5366af6897907934d469f723d9ad8ec
Reviewed-on: https://chromium-review.googlesource.com/738186
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511477}
[modify] https://crrev.com/fd35a843845c1820d06082fd2edf780abcd442e6/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by pdr@chromium.org, Oct 25 2017

Cc: alph@chromium.org
 Issue 778296  has been merged into this issue.

Comment 3 by pdr@chromium.org, Oct 25 2017

Cc: -alph@chromium.org
Labels: -Pri-3 Pri-2
Owner: alph@chromium.org
Status: Assigned (was: Untriaged)
Does this have an owner?

If not, I think this could have been Alexei's change. Here's the regression range:
https://chromium.googlesource.com/chromium/src/+log/1710eafbcfae3cb1b995adb6804d1c75ddc98866%5E..9044af2941b48986a24c65852281146d07e11df0?pretty=fuller&n=
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e956deeaf2ab913c3f1f82b56fc9f7e885209fc

commit 9e956deeaf2ab913c3f1f82b56fc9f7e885209fc
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Oct 25 20:54:33 2017

Revert "DevTools: Report column number for FunctionCall trace events."

This reverts commit 9044af2941b48986a24c65852281146d07e11df0.

Reason for revert: Accusingly broke http/tests/devtools/tracing/frame-model-instrumentation.html

Original change's description:
> DevTools: Report column number for FunctionCall trace events.
> 
> This is needed to properly map pretty-printed source.
> 
> BUG= 777159 
> 
> Change-Id: I3b78e70d96a26461369f9543ac5cb03e24e2ca1f
> Reviewed-on: https://chromium-review.googlesource.com/734424
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#511333}

TBR=alph@chromium.org,caseq@chromium.org

Change-Id: Ia3b1ab1afbfd88c07b52f899a4ed5252558cde67
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  777159 , 778271 
Reviewed-on: https://chromium-review.googlesource.com/738632
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511580}
[modify] https://crrev.com/9e956deeaf2ab913c3f1f82b56fc9f7e885209fc/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-expected.txt
[modify] https://crrev.com/9e956deeaf2ab913c3f1f82b56fc9f7e885209fc/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/9e956deeaf2ab913c3f1f82b56fc9f7e885209fc/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eeb7f2ee0a5887cd699f624e7ecffbd183bffb0

commit 7eeb7f2ee0a5887cd699f624e7ecffbd183bffb0
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Oct 25 20:58:40 2017

Revert "Update expectations on frame-model-instrumentation.html. The test fails on Win."

This reverts commit fd35a843845c1820d06082fd2edf780abcd442e6.

Reason for revert: The offending patch has been reverted, so revert the expectations.

Original change's description:
> Update expectations on frame-model-instrumentation.html. The test fails on Win.
> 
> TBR=chenwilliam@chromium.org
> 
> Bug:  778271 
> Change-Id: Ic92566b7b5366af6897907934d469f723d9ad8ec
> Reviewed-on: https://chromium-review.googlesource.com/738186
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#511477}

TBR=vasilii@chromium.org

Change-Id: I0de153e15cc15eec5f91f414176b760513b47635
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  778271 
Reviewed-on: https://chromium-review.googlesource.com/737964
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511582}
[modify] https://crrev.com/7eeb7f2ee0a5887cd699f624e7ecffbd183bffb0/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by alph@chromium.org, Oct 25 2017

Status: Fixed (was: Assigned)
The patch and the expectations change have been reverted.

Comment 7 by alph@chromium.org, Oct 26 2017

Cc: chenwilliam@chromium.org
Owner: ----
Status: Untriaged (was: Fixed)
@pdr I reverted my patch, but the test still failing.

It looks like the test was timeout-ing before that build, but the message was different. Could the message change caused by Will's changes?
 Issue 778651  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeea38fa7db53bff635b10e5e66c7e35a466c66e

commit aeea38fa7db53bff635b10e5e66c7e35a466c66e
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Oct 26 13:01:25 2017

Reland "Update expectations on frame-model-instrumentation.html. The test fails on Win."

This is a reland of fd35a843845c1820d06082fd2edf780abcd442e6
Original change's description:
> Update expectations on frame-model-instrumentation.html. The test fails on Win.
> 
> TBR=chenwilliam@chromium.org
> 
> Bug:  778271 
> Change-Id: Ic92566b7b5366af6897907934d469f723d9ad8ec
> Reviewed-on: https://chromium-review.googlesource.com/738186
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#511477}

TBR=chenwilliam@chromium.org,alph@chromium.org

Bug:  778271 
Change-Id: I4081ce7d13cb3be2cde42aae0d57a76a8434de87
Reviewed-on: https://chromium-review.googlesource.com/737999
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511799}
[modify] https://crrev.com/aeea38fa7db53bff635b10e5e66c7e35a466c66e/third_party/WebKit/LayoutTests/TestExpectations

Owner: alph@chromium.org
Status: Assigned (was: Untriaged)

Comment 11 by alph@chromium.org, Nov 1 2017

Owner: ----
Status: Untriaged (was: Assigned)
As I mentioned in comment #7, my patch is not the culprit.

Comment 12 by alph@chromium.org, Nov 1 2017

Labels: Needs-Bisect
Labels: TE-NeedsTriageHelp

Comment 14 by l...@chromium.org, Nov 13 2017

Cc: -chenwilliam@chromium.org caseq@chromium.org
Owner: chenwilliam@chromium.org
Status: Assigned (was: Untriaged)
Temporarily assigning to chenwilliam@: have you seen this `Internal watchdog` error before?

Otherwise, could caseq@, the test's original author please take a look?
Status: Started (was: Assigned)
Figured it out! https://chromium-review.googlesource.com/c/chromium/src/+/769243
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/653ae3bad41523719688a36f401fbce8317fbc7a

commit 653ae3bad41523719688a36f401fbce8317fbc7a
Author: Will Chen <chenwilliam@chromium.org>
Date: Tue Nov 14 20:12:52 2017

DevTools: remove watchdog and fix frame-model-instrumentation.html

A couple of errors with our old test harness (inspector-test.js) caused
frame-model-instrumentation.html to be flaky in Windows Debug because the
watchdog timer was erroneously being set due to rAF calling its callback
function with a number, and our runTest being called with an incorrect
number of parameters. Only the Windows Debug machine ran the test slowly
enough that it was around the 20 second watchdog threshold, which is why
it looked like it was a platform-specific flakiness.

Watchdog is a very old functionality that seems like it was intended for
debugging tests, but the layout test framework now properly handles tests
that timeout.

Bug:  778271 
Change-Id: I3f1f254cc0e3164beb8899b71e929557b70b0557
Reviewed-on: https://chromium-review.googlesource.com/769243
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516401}
[modify] https://crrev.com/653ae3bad41523719688a36f401fbce8317fbc7a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/653ae3bad41523719688a36f401fbce8317fbc7a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

Labels: -Needs-Bisect
Removing the Needs-Bisect label as the fix for this issue has already been landed and work has been started by chenwilliam@.
Please feel free to add the same if required.

Thanks...!!
Status: Fixed (was: Started)

Sign in to add a comment