New issue
Advanced search Search tips

Issue 778259 link

Starred by 3 users
Status: Fixed
Owner:
sunyunjia@chromium.org
Closed: Jul 3
Cc:
sunyunjia@chromium.org
bokan@chromium.org
majidvp@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 497851


Participants' hotlists:
Snap-Points-M69-Block


Sign in to add a comment

[css-scroll-snap] Implement scroll snapping for fling on main thread

Project Member Reported by sunyunjia@chromium.org, Oct 25 2017 
Once we have implemented scroll snapping for GestureScrollEnd, we would implement the snapping for GestureFling. The target for this implementation includes:
- Implementation of fling curve adjustment
- Implementation of snap algorithm for intended direction and end position
- Select snap points on the visibility corridor.

Comment 1 by dtapu...@chromium.org, Nov 1 2017

Components: Blink>Scroll

Comment 2 by sunyunjia@chromium.org, Feb 5 2018

Description: Show this description

Comment 3 by sunyunjia@chromium.org, Feb 5 2018

Labels: -Pri-3 Pri-1
Summary: Implement scroll snapping at GestureFling (was: Implement scroll snapping at GestureFling on main thread)

Comment 4 by sunyunjia@chromium.org, Mar 1 2018

Cc: bokan@chromium.org sunyunjia@chromium.org
 Issue 817129  has been merged into this issue.

Comment 5 by majidvp@chromium.org, Mar 14 2018

Blocking: 497851

Comment 6 by majidvp@chromium.org, Mar 14 2018

Status: Started (was: Assigned)

Comment 7 by majidvp@chromium.org, Mar 14 2018

Summary: Implement scroll snapping for fling (was: Implement scroll snapping at GestureFling)

Comment 8 by bokan@chromium.org, Mar 22 2018

Labels: -Pri-1 Pri-2
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb85637d61d178e82f65822dc40c4c037ef50af6

commit eb85637d61d178e82f65822dc40c4c037ef50af6
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Thu Mar 22 22:35:16 2018

Snap for GestureFling at cc side.

This patch implements snapping for gesture fling.

After receiving an inertial GSU, we create a SnapFlingCurve if the
currently scrolling node has some snap positions. We then animate
the SnapFlingCurve and ignore the following GSUs and GSE so that the
fling would land on an valid snap position.

Bug:  778259 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ib7f9a191adf02af96b9c986e016f5c75cdc591d9
Reviewed-on: https://chromium-review.googlesource.com/901022
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545272}
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/cc/input/input_handler.h
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/cc/input/scroll_snap_data.cc
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/cc/input/scroll_snap_data.h
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/cc/input/scroll_snap_data_unittest.cc
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/BUILD.gn
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/blink/BUILD.gn
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/blink/input_handler_proxy_unittest.cc
[add] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/blink/snap_fling_controller.cc
[add] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/blink/snap_fling_controller.h
[add] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/blink/snap_fling_controller_unittest.cc
[add] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/blink/snap_fling_curve.cc
[add] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/blink/snap_fling_curve.h
[add] https://crrev.com/eb85637d61d178e82f65822dc40c4c037ef50af6/ui/events/blink/snap_fling_curve_unittest.cc

Comment 11 by sunyunjia@chromium.org, May 4 2018

Summary: [css-scroll-snap] Implement scroll snapping for fling (was: Implement scroll snapping for fling)

Comment 12 by majidvp@chromium.org, May 10 2018

Summary: [css-scroll-snap] Implement scroll snapping for fling on main thread (was: [css-scroll-snap] Implement scroll snapping for fling)
Updated the issue title to reflect the fact that impl side is complete since comment #9.
Project Member

Comment 13 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa703718de4df93643651d101b6f9d9386eab12c

commit aa703718de4df93643651d101b6f9d9386eab12c
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Thu May 17 14:47:14 2018

Move snap fling logic to cc.

We plan to share the snap fling logic between cc and blink. But with the
dependency restrictions, we can only put the shared logic under cc/.
This patch moves the logic from ui/ to cc/, in preparation for blink to
use the same logic to make snap fling works there.

As cc/ doesn't accept blink::WebGestureEvent and blink::WebInputEvent,
we create GestureScrollType and GestureScrollUpdateInfo to pass in the
necessary messages.

Bug:  778259 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0df8cf1002d51646404310ca50eb00a536e0b5d1
Reviewed-on: https://chromium-review.googlesource.com/1024198
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559533}
[modify] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/cc/BUILD.gn
[rename] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/cc/input/snap_fling_controller.cc
[rename] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/cc/input/snap_fling_controller.h
[rename] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/cc/input/snap_fling_controller_unittest.cc
[rename] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/cc/input/snap_fling_curve.cc
[rename] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/cc/input/snap_fling_curve.h
[rename] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/cc/input/snap_fling_curve_unittest.cc
[modify] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/ui/events/BUILD.gn
[modify] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/ui/events/blink/BUILD.gn
[modify] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/ui/events/blink/DEPS
[modify] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/ui/events/blink/blink_event_util.h
[modify] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/aa703718de4df93643651d101b6f9d9386eab12c/ui/events/blink/input_handler_proxy.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80efb867e5d43071cd474384543231908911c395

commit 80efb867e5d43071cd474384543231908911c395
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Tue Jul 03 17:11:24 2018

Snap for GestureFling on main thread.

This patch implements snapping for gesture fling on main thread.
The ScrollManager would implement SnapFlingClient to collect snap
information, schedule animation, and execute the scroll as instructed
by SnapFlingController.

This patch also updates the interface of
SnapCoordinator::GetPositionForPoint() for it to return an Optional
FloatPoint, clearly indicating whether there exists a snap point for
the current scroll.

Bug:  778259 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I196e8c58c238cfad2a96e3f6a1c218f2c4f77a3c
Reviewed-on: https://chromium-review.googlesource.com/1083144
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572263}
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/cc/input/snap_fling_controller.h
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/cc/trees/layer_tree_host_impl.h
[add] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/WebKit/LayoutTests/fast/scroll-snap/animate-fling-to-snap-points.html
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/WebKit/LayoutTests/resources/gesture-util.js
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/public/platform/web_input_event.h
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/input/event_handler.h
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/input/scroll_manager.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/input/scroll_manager.h
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/input/scroll_snap_test.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/page/page_animator.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/page/scrolling/snap_coordinator.h
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/core/page/scrolling/snap_coordinator_test.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/platform/geometry/float_point.cc
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/platform/geometry/float_point.h
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/renderer/platform/scroll/scroll_snap_data.h
[modify] https://crrev.com/80efb867e5d43071cd474384543231908911c395/third_party/blink/tools/audit_non_blink_usage.py

Comment 15 by sunyunjia@chromium.org, Jul 3

Status: Fixed (was: Started)
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1

commit d352e8e7fbf02a4bd87207f4990ab56dcb013dc1
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Jul 03 20:54:15 2018

Revert "Snap for GestureFling on main thread."

This reverts commit 80efb867e5d43071cd474384543231908911c395.

Reason for revert: The new test fast/scroll-snap/animate-fling-to-snap-points.html is very flaky:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=fast%2Fscroll-snap%2Fanimate-fling-to-snap-points.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=fast%2Fscroll-snap%2Fanimate-fling-to-snap-points.html

Original change's description:
> Snap for GestureFling on main thread.
> 
> This patch implements snapping for gesture fling on main thread.
> The ScrollManager would implement SnapFlingClient to collect snap
> information, schedule animation, and execute the scroll as instructed
> by SnapFlingController.
> 
> This patch also updates the interface of
> SnapCoordinator::GetPositionForPoint() for it to return an Optional
> FloatPoint, clearly indicating whether there exists a snap point for
> the current scroll.
> 
> Bug:  778259 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I196e8c58c238cfad2a96e3f6a1c218f2c4f77a3c
> Reviewed-on: https://chromium-review.googlesource.com/1083144
> Reviewed-by: Rick Byers <rbyers@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572263}

TBR=rbyers@chromium.org,bokan@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org

Change-Id: Ie5add53034eb8558bd7df1c4efc17388065cbee5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  778259 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1124910
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572345}
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/cc/input/snap_fling_controller.h
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/cc/trees/layer_tree_host_impl.h
[delete] https://crrev.com/b4a829e9700548967ef916f94db1953c66ce0e47/third_party/WebKit/LayoutTests/fast/scroll-snap/animate-fling-to-snap-points.html
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/WebKit/LayoutTests/resources/gesture-util.js
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/public/platform/web_input_event.h
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/input/event_handler.h
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/input/scroll_manager.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/input/scroll_manager.h
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/input/scroll_snap_test.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/page/page_animator.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/page/scrolling/snap_coordinator.h
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/core/page/scrolling/snap_coordinator_test.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/platform/geometry/float_point.cc
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/platform/geometry/float_point.h
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/renderer/platform/scroll/scroll_snap_data.h
[modify] https://crrev.com/d352e8e7fbf02a4bd87207f4990ab56dcb013dc1/third_party/blink/tools/audit_non_blink_usage.py
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c82a29cd12796c080cd631c2114d0c5f207636fc

commit c82a29cd12796c080cd631c2114d0c5f207636fc
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Thu Jul 05 00:41:44 2018

Reland "Snap for GestureFling on main thread."

This is a reland of 80efb867e5d43071cd474384543231908911c395.
It adjusts the parameters in the test to make it less flaky.

Original change's description:
> This patch implements snapping for gesture fling on main thread.
> The ScrollManager would implement SnapFlingClient to collect snap
> information, schedule animation, and execute the scroll as instructed
> by SnapFlingController.
>
> This patch also updates the interface of
> SnapCoordinator::GetPositionForPoint() for it to return an Optional
> FloatPoint, clearly indicating whether there exists a snap point for
> the current scroll.
>
> Bug:  778259 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I196e8c58c238cfad2a96e3f6a1c218f2c4f77a3c
> Reviewed-on: https://chromium-review.googlesource.com/1083144
> Reviewed-by: Rick Byers <rbyers@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572263}

TBR=bokan@chromium.org, majidvp@chromium.org, rbyers@chromium.org

Bug:  778259 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie1fa0eed293e348916e0eb2c87ed84a07def4dfd
Reviewed-on: https://chromium-review.googlesource.com/1126491
Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572684}
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/cc/input/snap_fling_controller.h
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/cc/trees/layer_tree_host_impl.h
[add] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/WebKit/LayoutTests/fast/scroll-snap/animate-fling-to-snap-points.html
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/WebKit/LayoutTests/resources/gesture-util.js
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/public/platform/web_input_event.h
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/input/event_handler.h
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/input/scroll_manager.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/input/scroll_manager.h
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/input/scroll_snap_test.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/page/page_animator.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/page/scrolling/snap_coordinator.h
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/core/page/scrolling/snap_coordinator_test.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/platform/geometry/float_point.cc
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/platform/geometry/float_point.h
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/renderer/platform/scroll/scroll_snap_data.h
[modify] https://crrev.com/c82a29cd12796c080cd631c2114d0c5f207636fc/third_party/blink/tools/audit_non_blink_usage.py

Comment 18 by h...@jonjohnjohnson.com, Dec 11 

sunyunjia@chromium.org Though at one point this seemed fixed in relation to all my test cases, as I've been testing along the way with Canary, it now seems to not be working in at least this case.

http://output.jsbin.com/gedurer/quiet (Version 73.0.3636.2 (Official Build) canary (64-bit))

When I use my trackpad to manually stop a horizontal scroll, snapping works, but if I use a two finger horizontal "fling",inertia stops between snap positions, not seeming to handle the gesture in a correct manner anymore.
►

Sign in to add a comment