New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 778247 link

Starred by 1 user
Status: Fixed
Owner:
kmilka@chromium.org
Closed: Sep 24
Cc:
█ ramyan@chromium.org
treib@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Local NTP: Keyboard focus on animated Doodle

Project Member Reported by treib@chromium.org, Oct 25 2017 
On the local NTP, if you click the CTA image for an animated Doodle to reveal the gif, then the gif gets a visible focus ring, which looks very odd.
On the remote NTP, the gif can also have a focus ring, but only if you actually tab to it, not if you click the CTA. It'd be nice to reproduce that behavior on the local NTP.

Comment 1 by mvanouwe...@chromium.org, Oct 25 2017

Labels: zine-triaged

Comment 2 by fhorschig@chromium.org, Dec 14 2017

Labels: -M-64 M-65
Triage ping: Has anything happened here? I assume we won't merge, so M-65?

Comment 3 by sfiera@chromium.org, May 7 2018

Owner: ----
Status: Available (was: Assigned)
(not working on client-side Chrome any more)

Comment 4 by kmilka@chromium.org, Aug 9

Cc: ramyan@chromium.org
Labels: NTPDoodle
Owner: kmilka@chromium.org

Comment 5 by kmilka@chromium.org, Sep 24

Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef3b56e85a9ac946b4d9aba5e113470eedabf684

commit ef3b56e85a9ac946b4d9aba5e113470eedabf684
Author: Kyle Milka <kmilka@chromium.org>
Date: Mon Sep 24 21:41:25 2018

[NTP] Hide focus on animated Doodles

Doodles only need a focus ring when tabbed to but not when clicked.

Bug:  778247 
Change-Id: Ida0556ae6f03f272d576d76d0842ae3ca42afa57
Reviewed-on: https://chromium-review.googlesource.com/1241313
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593696}
[modify] https://crrev.com/ef3b56e85a9ac946b4d9aba5e113470eedabf684/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/ef3b56e85a9ac946b4d9aba5e113470eedabf684/chrome/browser/resources/local_ntp/local_ntp.html

Comment 7 by kmilka@chromium.org, Sep 24

Status: Fixed (was: Started)
►

Sign in to add a comment