New issue
Advanced search Search tips

Issue 778239 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 785055



Sign in to add a comment

org.chromium.chrome.browser.searchwidget.SearchActivityTest#testStartsBrowserAfterUrlSubmitted_aboutblank flaky

Project Member Reported by vasi...@chromium.org, Oct 25 2017

Issue description

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/46643

java.lang.AssertionError: Activity didn't start
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertNotNull(Assert.java:712)
	at org.chromium.chrome.browser.searchwidget.SearchActivityTest.waitForChromeTabbedActivityToStart(SearchActivityTest.java:491)
	at org.chromium.chrome.browser.searchwidget.SearchActivityTest.verifyUrlLoads(SearchActivityTest.java:203)
	at org.chromium.chrome.browser.searchwidget.SearchActivityTest.testStartsBrowserAfterUrlSubmitted_aboutblank(SearchActivityTest.java:176)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.chromium.chrome.test.MultiActivityTestRule$1.evaluate(MultiActivityTestRule.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:184)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:41)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:166)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:100)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
Searching for native crashes in: /b/swarming/w/itXBCcQC/tmpGONL4g
Unknown Android release, consider passing --packed-lib.
Reading Android symbols from: /b/swarming/w/ir
Searching for Chrome symbols from within: /b/swarming/w/ir/out/Debug/lib.unstripped:/b/swarming/w/ir/out/Debug/lib:/b/swarming/w/ir/out/Debug
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cba33b108c9fecbe08fd8e96f6c008f4849a5c7

commit 9cba33b108c9fecbe08fd8e96f6c008f4849a5c7
Author: Ted Choc <tedchoc@google.com>
Date: Wed Nov 01 00:09:00 2017

Add additional logging in SearchActivityTest to diagnose flakes.

This removes the similar Activity launching logic in SearchActivityTest
and replaces it with the same functionality in ActivityUtils.  In
addition, it adds additional logs in ActivityUtils on failure to
attempt to help figure out what the state of the system is.

BUG=778239

Change-Id: Ic2aac185958044a8ba733213ac8daf5a4c8aa618
Reviewed-on: https://chromium-review.googlesource.com/738843
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513016}
[modify] https://crrev.com/9cba33b108c9fecbe08fd8e96f6c008f4849a5c7/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java
[modify] https://crrev.com/9cba33b108c9fecbe08fd8e96f6c008f4849a5c7/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ActivityUtils.java

Cc: yus...@chromium.org
Components: UI>Browser>Mobile>SearchWidget

Comment 3 by kbr@chromium.org, Dec 21 2017

Blocking: 785055
Labels: -Pri-3 Pri-1
This is now affecting the linux_android_rel_ng tryserver, which is very flaky due to failures across multiple tests. Consequently I'm upgrading this to P1.

This related test:
org.chromium.chrome.browser.searchwidget.SearchActivityTest#testStartsBrowserAfterUrlSubmitted_chromeUrl

failed in this tryjob:
https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/456987

of this unrelated CL:
https://chromium-review.googlesource.com/822596

I'm not sure where the abovementioned additional logging went. It doesn't seem to be in the logcat.

Cc: -yus...@chromium.org tedc...@chromium.org
Owner: yus...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to yusufo@ to investigate more.

Along with: https://bugs.chromium.org/p/chromium/issues/detail?id=765476, these tests need a bit of love it seems.

The failure kbr@ saw last is different from the original bug description.  In my quick look, it seems like more things are failing for the omnibox suggestions to appear and not just start the activity.

Sign in to add a comment