New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778237 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Firmware updater for coral depends on order of models

Project Member Reported by sjg@chromium.org, Oct 25 2017

Issue description

At present pack_firmware expects the primary model to be first in the master config. This is normally the case but this assumption is broken with recent changes to the get_dtb_data() function.

Those changes need to be reverted, but in any case it should not be necessary to put the primary model first.

 

Comment 1 by pbe...@chromium.org, Oct 25 2017

Cc: yueherngl@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/a2de5676e07dd8ab24d93252a97a19adf644db64

commit a2de5676e07dd8ab24d93252a97a19adf644db64
Author: Simon Glass <sjg@chromium.org>
Date: Wed Nov 01 00:31:02 2017

pack_firmware: Don't depend on ordering of the models

At present the firmware updater packs the firmware in the order given by
the caller. This was fine before we had shared firmware, or when the
config is ordered that way. With split firmware the config fragments may
be installed in any order, or even once we fix that, the main fragment may
not actually mention the 'main' model (e.g. 'coral'). In any case we have
no validation on the order of the models so should not rely on it.

If the ordering is wrong, the firmware updater still works, but it may
write the firmware into the updater multiple times.

Adjust the updater to put the images in a directory named after the model
providing the shared firmware, and the setvars.sh scripts where they are
now. This ensures that each firmware binary appears only once.

BUG= chromium:778237 
TEST=emerge-coral chromeos-firmware-update
(using a master configuration where coral is not first in the list)
See that the update generated only includes the images once, and still
passes all tests.

Change-Id: Icee96093aaf83e035d68ce0c185954c3dd2cf26a
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/742472
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/a2de5676e07dd8ab24d93252a97a19adf644db64/pack_firmware.py

Comment 3 by sjg@chromium.org, Nov 4 2017

Labels: Unibuild

Comment 4 by sjg@chromium.org, Nov 6 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment