New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778233 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task

Blocked on:
issue 778232

Blocking:
issue 768876



Sign in to add a comment

Ramping up a new iOS 9 bot

Project Member Reported by noyau@chromium.org, Oct 25 2017

Issue description

The chrome iOS build needs a new bot on the waterfall, probably in the FYI category, to continue building the web_view target and run all its tests on with a minimum deployment target of iOS 9. The main iOS bots are going to transition to a target of iOS 10, but web_view needs to be kept compiling in iOS 9 as it is used by other clients.

It appear that it may be possible to recycle hardware used by the main iOS bots as those will stop building for iOS 9, liberating resources. see  https://crbug.com/778232 

 

Comment 1 by noyau@chromium.org, Oct 25 2017

Blocking: 768876

Comment 2 by baxley@chromium.org, Oct 25 2017

Cc: huangml@chromium.org
+huangml who is addressing capacity concerns right now.
Targets we want to build:
 * ios/web_view
 
Tests we want to run:
 * ios_web_view_unittests
 * ios_web_view_inttests
 * ios_components_unittests
 * components_unittests
 * net_unittests
 * ios_net_unittests
 * ios_web_unittests
 * ios_web_inttests
 * ios_web_shell_egtests

We should still be able to build and run on iOS 9 simulators with xcode 9,  and we don't actually run on devices upstream.  So running these tests on fyi would have no problem.  We can rum=n them on the existing chromium.fyi/ios-simulator or chromium.fyi/EarlGreyiOS bot,  probably don't need to ramp up a new bot for iOS9.
Oh I might mis-understood the issue here.  If we want bots keep building and running on devices for iOS 9 downstream,  we should keep some of the iOS 9 devices and set up a new internal.fyi device bot. 
Blockedon: 778232
Components: -Infra>Client>iOS Infra>Client>Chrome
Question: does the bot need to be public (upstream) or internal (downstream)?

I'm guessing it upstream, but would like to confirm.
The bot need to be public (upstream). Thanks!
Do we want a specific bot for web targets?

I just removed all useful tests from FYI.ios-simulator and FYI.EarlGreyiOS to main waterfall.  They can be used for experiment now.  We can put iOS9 targets on them as well.
Cc: sergeybe...@chromium.org
Owner: shenghua...@chromium.org
+shenghuazhang@ - would you be able to take a look at this? I think it's related to another issue you've already worked on, but I can't find it at the moment...
Status: Started (was: Assigned)
Discussed with huangml@, we can merge tests on FYI.ios-simulator and FYI.EarlGreyiOS to single bot, and reuse the other for the new bot.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/aca402590e6254f0fdc5edc50d47b25db2019584

commit aca402590e6254f0fdc5edc50d47b25db2019584
Author: Shenghua Zhang <shenghuazhang@chromium.org>
Date: Tue Nov 14 23:01:58 2017

[ios] Remove EarlGreyiOS bot and reuse it as bot ios-webview

Bug:778233
Change-Id: Ia93f01ad4f577c962d953072b4ca41a506b7d2e1
Reviewed-on: https://chromium-review.googlesource.com/769659
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>

[modify] https://crrev.com/aca402590e6254f0fdc5edc50d47b25db2019584/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/aca402590e6254f0fdc5edc50d47b25db2019584/masters/master.chromium.fyi/slaves.cfg

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/819aa9caee3ecba9c27f045af0bf8e63d7bd9708

commit 819aa9caee3ecba9c27f045af0bf8e63d7bd9708
Author: Shenghua Zhang <shenghuazhang@chromium.org>
Date: Tue Nov 14 23:27:36 2017

[ios] Add json file for new bot ios-webview

New bot ios-webview runs web_view tests for ios 9 simulators on FYI bot.

Bug:  778233 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7c32e7360e4c91b395eb9703d321c84f93227f8f
Reviewed-on: https://chromium-review.googlesource.com/769656
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516493}
[add] https://crrev.com/819aa9caee3ecba9c27f045af0bf8e63d7bd9708/ios/build/bots/chromium.fyi/ios-webview.json

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/dc27aa3c0e14d4f086e43d7c8d4675e7ad58baf5

commit dc27aa3c0e14d4f086e43d7c8d4675e7ad58baf5
Author: Shenghua Zhang <shenghuazhang@google.com>
Date: Wed Nov 15 00:08:15 2017

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73488c0082b5a59e2d659e55dcfc80f101976c4c

commit 73488c0082b5a59e2d659e55dcfc80f101976c4c
Author: Shenghua Zhang <shenghuazhang@chromium.org>
Date: Wed Nov 15 01:00:56 2017

[ios] Merge bot FYI.EarlGreyiOS tests to FYI.ios-simulator

And delete the FYI.EarlGreyiOS json file since the bot could be removed/reused.

Bug:  778233 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6591e6578a726c3bcc8a96bcd17166a548f4e022
Reviewed-on: https://chromium-review.googlesource.com/769789
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516533}
[delete] https://crrev.com/2ec4a683fd08a735139806846846bb3dfedf2f58/ios/build/bots/chromium.fyi/EarlGreyiOS.json
[modify] https://crrev.com/73488c0082b5a59e2d659e55dcfc80f101976c4c/ios/build/bots/chromium.fyi/ios-simulator.json

Status: Fixed (was: Started)
New builder ios-webview is green on fyi bot:
https://build.chromium.org/p/chromium.fyi/builders/ios-webview

Please let me know if has other request on this bug.

Mark this bug as fixed.

Sign in to add a comment