New issue
Advanced search Search tips

Issue 778227 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 769439



Sign in to add a comment

base_unittests doesn't compile under simple chrome for chromeos

Project Member Reported by achuith@chromium.org, Oct 25 2017

Issue description

Looks like it's these 2 files:
span_unittest.cc
partition_alloc_unittest.cc

(sdk amd64-generic R64-10041.0.0-b19954) achuith@achuith ~/code/chrome/src $ ninja -C out_$SDK_BOARD/Release/ -j1000 -l20 base_unittests
ninja: Entering directory `out_amd64-generic/Release/'
[1/3] CXX obj/base/base_unittests/span_unittest.o
FAILED: obj/base/base_unittests/span_unittest.o 
/media/achuith/DATA/code/chrome/.cros_cache/common/goma+2/gomacc x86_64-cros-linux-gnu-clang++ -B/media/achuith/DATA/code/chrome/.cros_cache/chrome-sdk/tarballs/amd64-generic+10041.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold -Wno-unknown-warning-option -MMD -MF obj/base/base_unittests/span_unittest.o.d -DSYSTEM_NATIVE_UTF8 -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCR_CLANG_REVISION=\"315613-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DUNIT_TEST -I../.. -Igen -I../../third_party/googletest/src/googletest/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/googletest/custom -I../../third_party/googletest/src/googlemock/include -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -no-canonical-prefixes -m64 -march=x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-unsigned-enum-zero-compare -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf -ggnu-pubnames -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti --sysroot=../../../.cros_cache/chrome-sdk/tarballs/amd64-generic+10041.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz -fno-exceptions -fvisibility-inlines-hidden -pipe -pipe -pipe -march=x86-64 -msse3 -fno-split-dwarf-inlining -fdebug-info-for-profiling -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -Wno-inline-asm -c ../../base/containers/span_unittest.cc -o obj/base/base_unittests/span_unittest.o
../../base/containers/span_unittest.cc:351:31: error: no member named 'rbegin' in namespace 'std'
  EXPECT_TRUE(std::equal(std::rbegin(kArray), std::rend(kArray), span.rbegin(),
                         ~~~~~^
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1860:24: note: expanded from macro 'EXPECT_TRUE'
  GTEST_TEST_BOOLEAN_((condition), #condition, false, true, \
                       ^~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:1215:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
      ::testing::AssertionResult(expression)) \
                                 ^~~~~~~~~~
../../base/containers/span_unittest.cc:351:52: error: no member named 'rend' in namespace 'std'
  EXPECT_TRUE(std::equal(std::rbegin(kArray), std::rend(kArray), span.rbegin(),
                                              ~~~~~^
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1860:24: note: expanded from macro 'EXPECT_TRUE'
  GTEST_TEST_BOOLEAN_((condition), #condition, false, true, \
                       ^~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:1215:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
      ::testing::AssertionResult(expression)) \
                                 ^~~~~~~~~~
../../base/containers/span_unittest.cc:353:31: error: no member named 'crbegin' in namespace 'std'
  EXPECT_TRUE(std::equal(std::crbegin(kArray), std::crend(kArray),
                         ~~~~~^
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1860:24: note: expanded from macro 'EXPECT_TRUE'
  GTEST_TEST_BOOLEAN_((condition), #condition, false, true, \
                       ^~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:1215:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
      ::testing::AssertionResult(expression)) \
                                 ^~~~~~~~~~
../../base/containers/span_unittest.cc:353:53: error: no member named 'crend' in namespace 'std'
  EXPECT_TRUE(std::equal(std::crbegin(kArray), std::crend(kArray),
                                               ~~~~~^
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1860:24: note: expanded from macro 'EXPECT_TRUE'
  GTEST_TEST_BOOLEAN_((condition), #condition, false, true, \
                       ^~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:1215:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
      ::testing::AssertionResult(expression)) \
                                 ^~~~~~~~~~
4 errors generated.
[2/3] CXX obj/base/base_unittests/partition_alloc_unittest.o
FAILED: obj/base/base_unittests/partition_alloc_unittest.o 
/media/achuith/DATA/code/chrome/.cros_cache/common/goma+2/gomacc x86_64-cros-linux-gnu-clang++ -B/media/achuith/DATA/code/chrome/.cros_cache/chrome-sdk/tarballs/amd64-generic+10041.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold -Wno-unknown-warning-option -MMD -MF obj/base/base_unittests/partition_alloc_unittest.o.d -DSYSTEM_NATIVE_UTF8 -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCR_CLANG_REVISION=\"315613-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DUNIT_TEST -I../.. -Igen -I../../third_party/googletest/src/googletest/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/googletest/custom -I../../third_party/googletest/src/googlemock/include -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -no-canonical-prefixes -m64 -march=x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-unsigned-enum-zero-compare -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf -ggnu-pubnames -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti --sysroot=../../../.cros_cache/chrome-sdk/tarballs/amd64-generic+10041.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz -fno-exceptions -fvisibility-inlines-hidden -pipe -pipe -pipe -march=x86-64 -msse3 -fno-split-dwarf-inlining -fdebug-info-for-profiling -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -Wno-inline-asm -c ../../base/allocator/partition_allocator/partition_alloc_unittest.cc -o obj/base/base_unittests/partition_alloc_unittest.o
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:310:18: error: constexpr variable 'kHugeMemoryAmount' must be initialized by a constant expression
constexpr size_t kHugeMemoryAmount =
                 ^
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:311:5: note: non-constexpr function 'max<unsigned long>' cannot be used in a constant expression
    std::max(base::internal::kASLRMask,
    ^
/media/achuith/DATA/code/chrome/.cros_cache/chrome-sdk/tarballs/amd64-generic+10041.0.0+target_toolchain/usr/bin/../lib/gcc/x86_64-cros-linux-gnu/4.9.x/include/g++-v4/bits/algorithmfwd.h:356:5: note: declared here
    max(const _Tp&, const _Tp&);
    ^
1 error generated.
ninja: build stopped: subcommand failed.

 
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/738193
I ran the tests, and the following 46 failed:
46 tests failed:
    BreakIteratorTest.BreakCharacter (../../base/i18n/break_iterator_unittest.cc:316)
    BreakIteratorTest.BreakLine (../../base/i18n/break_iterator_unittest.cc:229)
    BreakIteratorTest.BreakLineEmpty (../../base/i18n/break_iterator_unittest.cc:219)
    BreakIteratorTest.BreakLineNL (../../base/i18n/break_iterator_unittest.cc:252)
    BreakIteratorTest.BreakLineWide16 (../../base/i18n/break_iterator_unittest.cc:275)
    BreakIteratorTest.BreakLineWide32 (../../base/i18n/break_iterator_unittest.cc:296)
    BreakIteratorTest.BreakSpace (../../base/i18n/break_iterator_unittest.cc:127)
    BreakIteratorTest.BreakSpaceEmpty (../../base/i18n/break_iterator_unittest.cc:117)
    BreakIteratorTest.BreakSpaceSP (../../base/i18n/break_iterator_unittest.cc:152)
    BreakIteratorTest.BreakSpaceWide32 (../../base/i18n/break_iterator_unittest.cc:198)
    BreakIteratorTest.BreakSpacekWide16 (../../base/i18n/break_iterator_unittest.cc:177)
    BreakIteratorTest.BreakWide16 (../../base/i18n/break_iterator_unittest.cc:69)
    BreakIteratorTest.BreakWide32 (../../base/i18n/break_iterator_unittest.cc:93)
    BreakIteratorTest.BreakWord (../../base/i18n/break_iterator_unittest.cc:28)
    BreakIteratorTest.BreakWordEmpty (../../base/i18n/break_iterator_unittest.cc:18)
    BreakIteratorTest.GetStringAfterSetText (../../base/i18n/break_iterator_unittest.cc:343)
    BreakIteratorTest.GetStringPiece (../../base/i18n/break_iterator_unittest.cc:360)
    BreakIteratorTest.GetWordBreakStatusBreakLine (../../base/i18n/break_iterator_unittest.cc:377)
    BreakIteratorTest.GetWordBreakStatusBreakWord (../../base/i18n/break_iterator_unittest.cc:409)
    CharacterEncodingTest.GetCanonicalEncodingNameByAliasName (../../base/i18n/character_encoding_unittest.cc:11)
    ChromeOSMemoryPressureMonitorTest.CheckMemoryPressure (../../base/memory/memory_pressure_monitor_chromeos_unittest.cc:76)
    FileUtilTest.ChangeDirectoryPermissionsAndEnumerate (../../base/files/file_util_unittest.cc:848)
    FileUtilTest.ChangeFilePermissionsAndRead (../../base/files/file_util_unittest.cc:768)
    FileUtilTest.ChangeFilePermissionsAndWrite (../../base/files/file_util_unittest.cc:806)
    FileUtilTest.SetCloseOnExec (../../base/files/file_util_unittest.cc:2560)
    FileUtilTest.SetNonBlocking (../../base/files/file_util_unittest.cc:2548)
    ICUStringConversionsTest.ConvertBetweenCodepageAndUTF16 (../../base/i18n/icu_string_conversions_unittest.cc:197)
    ICUStringConversionsTest.ConvertToUtf8AndNormalize (../../base/i18n/icu_string_conversions_unittest.cc:251)
    JSONFileValueSerializerTest.NoWhitespace (../../base/json/json_value_serializer_unittest.cc:474)
    JSONFileValueSerializerTest.Roundtrip (../../base/json/json_value_serializer_unittest.cc:405)
    JSONFileValueSerializerTest.RoundtripNested (../../base/json/json_value_serializer_unittest.cc:448)
    JSONReaderTest.ReadFromFile (../../base/json/json_reader_unittest.cc:570)
    MessageFormatterTest.PluralNamedArgs (../../base/i18n/message_formatter_unittest.cc:50)
    MessageFormatterTest.PluralNamedArgsWithOffset (../../base/i18n/message_formatter_unittest.cc:68)
    MessageFormatterTest.PluralNumberedArgs (../../base/i18n/message_formatter_unittest.cc:98)
    NumberFormattingTest.FormatDouble (../../base/i18n/number_formatting_unittest.cc:51)
    NumberFormattingTest.FormatNumber (../../base/i18n/number_formatting_unittest.cc:22)
    NumberFormattingTest.FormatPercent (../../base/i18n/number_formatting_unittest.cc:97)
    PathServiceTest.Get (../../base/path_service_unittest.cc:79)
    RTLTest.GetTextDirection (../../base/i18n/rtl_unittest.cc:380)
    ReadOnlyFileUtilTest.ContentsEqual (../../base/files/file_util_unittest.cc:1877)
    ReadOnlyFileUtilTest.TextContentsEqual (../../base/files/file_util_unittest.cc:1923)
    TaskSchedulerWorkerTest.BumpPriorityOfAliveThreadDuringShutdown (../../base/task_scheduler/scheduler_worker_unittest.cc:732)
    TimeFormattingTest.TimeDurationFormat (../../base/i18n/time_formatting_unittest.cc:274)
    TimeFormattingTest.TimeDurationFormatWithSeconds (../../base/i18n/time_formatting_unittest.cc:319)
    TimeFormattingTest.TimeIntervalFormat (../../base/i18n/time_formatting_unittest.cc:368)
12 tests crashed:
    MessageFormatterTest.DateTimeAndNumber (../../base/i18n/message_formatter_unittest.cc:139)
    MessageFormatterTest.PluralNumberedArgsWithDate (../../base/i18n/message_formatter_unittest.cc:116)
    StringSearchTest.ASCII (../../base/i18n/string_search_unittest.cc:25)
    StringSearchTest.FixedPatternMultipleSearch (../../base/i18n/string_search_unittest.cc:204)
    StringSearchTest.UnicodeLocaleDependent (../../base/i18n/string_search_unittest.cc:185)
    StringSearchTest.UnicodeLocaleIndependent (../../base/i18n/string_search_unittest.cc:67)
    TimeFormattingTest.TimeFormatDateGB (../../base/i18n/time_formatting_unittest.cc:229)
    TimeFormattingTest.TimeFormatDateUS (../../base/i18n/time_formatting_unittest.cc:198)
    TimeFormattingTest.TimeFormatTimeOfDayDefault12h (../../base/i18n/time_formatting_unittest.cc:73)
    TimeFormattingTest.TimeFormatTimeOfDayDefault24h (../../base/i18n/time_formatting_unittest.cc:116)
    TimeFormattingTest.TimeFormatTimeOfDayJP (../../base/i18n/time_formatting_unittest.cc:158)
    TimeFormattingTest.TimeFormatWithPattern (../../base/i18n/time_formatting_unittest.cc:251)
Tests took 30 seconds.

Blockedon: 769439
Cc: manojgupta@chromium.org
Manoj, do you think these compile errors go away with your work in 769439? 
I believe that the errors should go away if in latest SimpleChrome environment (It should have -stdlib=libc++ in the command line).
Status: Fixed (was: Started)
The compilation failures go away in R64-10070.0.0-b20063.

We still have a bunch of runtime failures. We can re-purpose this bug or use a new one to track/fix these:

46 tests failed:
    BreakIteratorTest.BreakCharacter (../../base/i18n/break_iterator_unittest.cc:316)
    BreakIteratorTest.BreakLine (../../base/i18n/break_iterator_unittest.cc:229)
    BreakIteratorTest.BreakLineEmpty (../../base/i18n/break_iterator_unittest.cc:219)
    BreakIteratorTest.BreakLineNL (../../base/i18n/break_iterator_unittest.cc:252)
    BreakIteratorTest.BreakLineWide16 (../../base/i18n/break_iterator_unittest.cc:275)
    BreakIteratorTest.BreakLineWide32 (../../base/i18n/break_iterator_unittest.cc:296)
    BreakIteratorTest.BreakSpace (../../base/i18n/break_iterator_unittest.cc:127)
    BreakIteratorTest.BreakSpaceEmpty (../../base/i18n/break_iterator_unittest.cc:117)
    BreakIteratorTest.BreakSpaceSP (../../base/i18n/break_iterator_unittest.cc:152)
    BreakIteratorTest.BreakSpaceWide32 (../../base/i18n/break_iterator_unittest.cc:198)
    BreakIteratorTest.BreakSpacekWide16 (../../base/i18n/break_iterator_unittest.cc:177)
    BreakIteratorTest.BreakWide16 (../../base/i18n/break_iterator_unittest.cc:69)
    BreakIteratorTest.BreakWide32 (../../base/i18n/break_iterator_unittest.cc:93)
    BreakIteratorTest.BreakWord (../../base/i18n/break_iterator_unittest.cc:28)
    BreakIteratorTest.BreakWordEmpty (../../base/i18n/break_iterator_unittest.cc:18)
    BreakIteratorTest.GetStringAfterSetText (../../base/i18n/break_iterator_unittest.cc:343)
    BreakIteratorTest.GetStringPiece (../../base/i18n/break_iterator_unittest.cc:360)
    BreakIteratorTest.GetWordBreakStatusBreakLine (../../base/i18n/break_iterator_unittest.cc:377)
    BreakIteratorTest.GetWordBreakStatusBreakWord (../../base/i18n/break_iterator_unittest.cc:409)
    CharacterEncodingTest.GetCanonicalEncodingNameByAliasName (../../base/i18n/character_encoding_unittest.cc:11)
    ChromeOSMemoryPressureMonitorTest.CheckMemoryPressure (../../base/memory/memory_pressure_monitor_chromeos_unittest.cc:76)
    FileUtilTest.ChangeDirectoryPermissionsAndEnumerate (../../base/files/file_util_unittest.cc:848)
    FileUtilTest.ChangeFilePermissionsAndRead (../../base/files/file_util_unittest.cc:768)
    FileUtilTest.ChangeFilePermissionsAndWrite (../../base/files/file_util_unittest.cc:806)
    FileUtilTest.SetCloseOnExec (../../base/files/file_util_unittest.cc:2560)
    FileUtilTest.SetNonBlocking (../../base/files/file_util_unittest.cc:2548)
    ICUStringConversionsTest.ConvertBetweenCodepageAndUTF16 (../../base/i18n/icu_string_conversions_unittest.cc:197)
    ICUStringConversionsTest.ConvertToUtf8AndNormalize (../../base/i18n/icu_string_conversions_unittest.cc:251)
    JSONFileValueSerializerTest.NoWhitespace (../../base/json/json_value_serializer_unittest.cc:474)
    JSONFileValueSerializerTest.Roundtrip (../../base/json/json_value_serializer_unittest.cc:405)
    JSONFileValueSerializerTest.RoundtripNested (../../base/json/json_value_serializer_unittest.cc:448)
    JSONReaderTest.ReadFromFile (../../base/json/json_reader_unittest.cc:570)
    MessageFormatterTest.PluralNamedArgs (../../base/i18n/message_formatter_unittest.cc:50)
    MessageFormatterTest.PluralNamedArgsWithOffset (../../base/i18n/message_formatter_unittest.cc:68)
    MessageFormatterTest.PluralNumberedArgs (../../base/i18n/message_formatter_unittest.cc:98)
    NumberFormattingTest.FormatDouble (../../base/i18n/number_formatting_unittest.cc:51)
    NumberFormattingTest.FormatNumber (../../base/i18n/number_formatting_unittest.cc:22)
    NumberFormattingTest.FormatPercent (../../base/i18n/number_formatting_unittest.cc:97)
    PathServiceTest.Get (../../base/path_service_unittest.cc:79)
    RTLTest.GetTextDirection (../../base/i18n/rtl_unittest.cc:380)
    ReadOnlyFileUtilTest.ContentsEqual (../../base/files/file_util_unittest.cc:1877)
    ReadOnlyFileUtilTest.TextContentsEqual (../../base/files/file_util_unittest.cc:1923)
    TaskSchedulerWorkerTest.BumpPriorityOfAliveThreadDuringShutdown (../../base/task_scheduler/scheduler_worker_unittest.cc:732)
    TimeFormattingTest.TimeDurationFormat (../../base/i18n/time_formatting_unittest.cc:274)
    TimeFormattingTest.TimeDurationFormatWithSeconds (../../base/i18n/time_formatting_unittest.cc:319)
    TimeFormattingTest.TimeIntervalFormat (../../base/i18n/time_formatting_unittest.cc:368)
14 tests crashed:
    MessageFormatterTest.DateTimeAndNumber (../../base/i18n/message_formatter_unittest.cc:139)
    MessageFormatterTest.PluralNumberedArgsWithDate (../../base/i18n/message_formatter_unittest.cc:116)
    NativeLibraryTest.LoadLibrary (../../base/native_library_unittest.cc:94)
    NativeLibraryTest.LoadLibraryPreferOwnSymbols (../../base/native_library_unittest.cc:110)
    StringSearchTest.ASCII (../../base/i18n/string_search_unittest.cc:25)
    StringSearchTest.FixedPatternMultipleSearch (../../base/i18n/string_search_unittest.cc:204)
    StringSearchTest.UnicodeLocaleDependent (../../base/i18n/string_search_unittest.cc:185)
    StringSearchTest.UnicodeLocaleIndependent (../../base/i18n/string_search_unittest.cc:67)
    TimeFormattingTest.TimeFormatDateGB (../../base/i18n/time_formatting_unittest.cc:229)
    TimeFormattingTest.TimeFormatDateUS (../../base/i18n/time_formatting_unittest.cc:198)
    TimeFormattingTest.TimeFormatTimeOfDayDefault12h (../../base/i18n/time_formatting_unittest.cc:73)
    TimeFormattingTest.TimeFormatTimeOfDayDefault24h (../../base/i18n/time_formatting_unittest.cc:116)
    TimeFormattingTest.TimeFormatTimeOfDayJP (../../base/i18n/time_formatting_unittest.cc:158)
    TimeFormattingTest.TimeFormatWithPattern (../../base/i18n/time_formatting_unittest.cc:251)
Tests took 30 seconds.

Let's use a new bug for test failures, to avoid confusion.

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment