New issue
Advanced search Search tips

Issue 778225 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Media Engagement: Threshold and min visits should be configurable

Project Member Reported by beccahughes@chromium.org, Oct 25 2017

Issue description

Upper / lower threshold and min visits should be finch configurable.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a5063981913208e3dc73b620d0dc8cbb16d5432

commit 0a5063981913208e3dc73b620d0dc8cbb16d5432
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Oct 26 11:41:52 2017

Media Engagement: Make scoring finch configurable

Add "min_visits", "lower_threshold" and "upper_threshold" experiment
params so we can experiment with the scoring algorithm.

BUG= 778225 

Change-Id: I39328e9f6e2a91ef975d94c120fd3f5c2fc84d4f
Reviewed-on: https://chromium-review.googlesource.com/738181
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511789}
[modify] https://crrev.com/0a5063981913208e3dc73b620d0dc8cbb16d5432/chrome/browser/media/media_engagement_score.cc
[modify] https://crrev.com/0a5063981913208e3dc73b620d0dc8cbb16d5432/chrome/browser/media/media_engagement_score.h
[modify] https://crrev.com/0a5063981913208e3dc73b620d0dc8cbb16d5432/chrome/browser/media/media_engagement_score_unittest.cc
[modify] https://crrev.com/0a5063981913208e3dc73b620d0dc8cbb16d5432/chrome/browser/media/media_engagement_service_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/306ba35bf631c6a4641b9139b944f1b40a8587ee

commit 306ba35bf631c6a4641b9139b944f1b40a8587ee
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Oct 27 09:18:20 2017

Media Engagement: Display internals on webui

Now that the internals are configurable it would be useful to display
the current state of the configuration on chrome://media-engagement for
easy debugging.

BUG= 778225 

Change-Id: Ie8192e5a8745c7053952d742e865ddb7aa1c7176
Reviewed-on: https://chromium-review.googlesource.com/738200
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512131}
[modify] https://crrev.com/306ba35bf631c6a4641b9139b944f1b40a8587ee/chrome/browser/media/media_engagement_score_details.mojom
[modify] https://crrev.com/306ba35bf631c6a4641b9139b944f1b40a8587ee/chrome/browser/resources/media/media_engagement.html
[modify] https://crrev.com/306ba35bf631c6a4641b9139b944f1b40a8587ee/chrome/browser/resources/media/media_engagement.js
[modify] https://crrev.com/306ba35bf631c6a4641b9139b944f1b40a8587ee/chrome/browser/ui/webui/media/media_engagement_ui.cc

Status: Fixed (was: Started)

Sign in to add a comment