New issue
Advanced search Search tips

Issue 778224 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

blink::CSSFontWeightInterpolationType::MaybeConvertValue NOTREACHED()

Project Member Reported by arthurso...@chromium.org, Oct 25 2017

Issue description

Chromium: 64.0.3250.0 (Developer Build) (64-bit)
Revision: 3379c434febfbea29a644ed6ebd0fc4059360770-
OS: Linux
Commit: bead99874c0f63f1ddf66963cd1af613b4a6531e

What steps will reproduce the problem?
* Navigate to https://www.google.com/intl/fr/docs/about/

Problem: NOTREACHED() reached.

# Stacktrace
17433:17433:1025/142520.991981:FATAL:CSSFontWeightInterpolationType.cpp(117)] Check failed: false. 
#0 0x2b279a225ddd base::debug::StackTrace::StackTrace()
#1 0x2b279a22420c base::debug::StackTrace::StackTrace()
#2 0x2b279a2aaf9a logging::LogMessage::~LogMessage()
#3 0x2b27ab1eeadb blink::CSSFontWeightInterpolationType::MaybeConvertValue()
#4 0x2b27ab1fc471 blink::CSSInterpolationType::MaybeConvertSingleInternal()
#5 0x2b27ab1fbe76 blink::CSSInterpolationType::MaybeConvertSingle()
#6 0x2b27ab1cb5d3 blink::InterpolationType::MaybeConvertPairwise()
#7 0x2b27ab269014 blink::InvalidatableInterpolation::MaybeConvertPairwise()
#8 0x2b27ab26afb6 blink::InvalidatableInterpolation::EnsureValidConversion()
#9 0x2b27ab26c2f6 blink::InvalidatableInterpolation::ApplyStack()
#10 0x2b27ab55cca4 blink::StyleResolver::ApplyAnimatedStandardProperties<>()
#11 0x2b27ab555e5e blink::StyleResolver::ApplyAnimatedStandardProperties()
#12 0x2b27ab55523a blink::StyleResolver::StyleForElement()
#13 0x2b27ab62fca4 blink::Element::OriginalStyleForLayoutObject()
#14 0x2b27ab62f885 blink::Element::StyleForLayoutObject()
#15 0x2b27ab630701 blink::Element::RecalcOwnStyle()
#16 0x2b27ab63010b blink::Element::RecalcStyle()
#17 0x2b27ab5a1bb7 blink::ContainerNode::RecalcDescendantStyles()
#18 0x2b27ab630281 blink::Element::RecalcStyle()
#19 0x2b27ab5a1bb7 blink::ContainerNode::RecalcDescendantStyles()
#20 0x2b27ab630281 blink::Element::RecalcStyle()
#21 0x2b27ab5a1bb7 blink::ContainerNode::RecalcDescendantStyles()
#22 0x2b27ab630281 blink::Element::RecalcStyle()
#23 0x2b27ab5a1bb7 blink::ContainerNode::RecalcDescendantStyles()
#24 0x2b27ab630281 blink::Element::RecalcStyle()
#25 0x2b27ab5a1bb7 blink::ContainerNode::RecalcDescendantStyles()
#26 0x2b27ab630281 blink::Element::RecalcStyle()
#27 0x2b27ab5a1bb7 blink::ContainerNode::RecalcDescendantStyles()
#28 0x2b27ab630281 blink::Element::RecalcStyle()
#29 0x2b27ab5a1bb7 blink::ContainerNode::RecalcDescendantStyles()
#30 0x2b27ab630281 blink::Element::RecalcStyle()
#31 0x2b27ab5a1bb7 blink::ContainerNode::RecalcDescendantStyles()
#32 0x2b27ab630281 blink::Element::RecalcStyle()
#33 0x2b27ab5cba7d blink::Document::UpdateStyle()
#34 0x2b27ab5c79dc blink::Document::UpdateStyleAndLayoutTree()
#35 0x2b27ab5cdd86 blink::Document::UpdateStyleAndLayoutTreeIgnorePendingStylesheets()
#36 0x2b27ab5cd66c blink::Document::UpdateStyleAndLayoutIgnorePendingStylesheets()
#37 0x2b27ab9bdcb6 blink::LocalDOMWindow::scrollY()
#38 0x2b27aca5b3d5 blink::LocalDOMWindow::pageYOffset()
#39 0x2b27aca1993b blink::DOMWindowV8Internal::pageYOffsetAttributeGetter()
#40 0x2b27aca198ca blink::V8Window::pageYOffsetAttributeGetterCallback()
#41 0x2b27a93862c2 v8::internal::FunctionCallbackArguments::Call()
#42 0x2b27a9484363 v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#43 0x2b27a9482bde v8::internal::Builtins::InvokeApiFunction()
#44 0x2b27a99d8768 v8::internal::Object::GetPropertyWithAccessor()
#45 0x2b27a98df78b v8::internal::LoadIC::Load()
#46 0x2b27a98ec363 v8::internal::__RT_impl_Runtime_LoadIC_Miss()
#47 0x1648aa404844 <unknown>

+CC drott@: FYI you are the last author of the 'NOTREACHED()' line.
 
Labels: Update-Weekly Stability-Crash
Owner: ericwilligers@chromium.org
Status: Started (was: Untriaged)
https://drafts.csswg.org/css-fonts-3/#font-weight-prop
normal | bold | bolder | lighter | ... (numeric)

CSSFontWeightInterpolationType::MaybeConvertValue
allows for normal | bolder | lighter but not bold.
The test case uses bold.

It should have a case for bold, with implementation similar to normal, but calling BoldWeightValue() 

Test cases need to be added to animations/interpolation/font-weight-interpolation.html
where the from or to value is normal and/or bold.

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64bffda61f3eaa0fe121fe621ea776a1c3f78419

commit 64bffda61f3eaa0fe121fe621ea776a1c3f78419
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Thu Oct 26 07:46:58 2017

CSS Animation: Support font-weight bold

https://drafts.csswg.org/css-fonts-3/#font-weight-prop
The implementation previously supported
'normal', 'bolder', 'lighter' but not 'bold'.

BUG= 778224 

Change-Id: Iec5976195faa43f7f1e3fd628f73a85017361cab
Reviewed-on: https://chromium-review.googlesource.com/737395
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511761}
[modify] https://crrev.com/64bffda61f3eaa0fe121fe621ea776a1c3f78419/third_party/WebKit/LayoutTests/animations/interpolation/font-weight-interpolation.html
[modify] https://crrev.com/64bffda61f3eaa0fe121fe621ea776a1c3f78419/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

Status: Fixed (was: Started)

Sign in to add a comment