Issue metadata
Sign in to add a comment
|
S13nServiceWorker: Support "Bypass for network" |
||||||||||||||||||||||
Issue descriptionCurrently DevTools LayoutTests (service-workers-bypass-for-network-navigation.html and service-workers-bypass-for-network-redirect.html) are crashing because ServiceWorkerURLTrackingRequestHandler which is used for skipping service worker doesn't implement MaybeCreateLoader().
,
Oct 25 2017
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e4271e15bf240edd313611750bcff9db8a8abca commit 1e4271e15bf240edd313611750bcff9db8a8abca Author: Tsuyoshi Horo <horo@chromium.org> Date: Wed Oct 25 14:03:56 2017 S13nSW: Add service-workers-bypass-for-network*.html tests in FlagExpectations In Debug build, service-workers-bypass-for-network-navigation.html and service-workers-bypass-for-network-redirect.html are crashing at NOTREACHED() in ServiceWorkerRequestHandler::MaybeCreateLoader(). In Release build, service-workers-bypass-for-network-navigation.html passes, but service-workers-bypass-for-network-redirect.html timeout. Bug: 778220 Change-Id: I83ed4edf1640ab7d0b65e1382fd568f614d0d09c Reviewed-on: https://chromium-review.googlesource.com/737492 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#511443} [modify] https://crrev.com/1e4271e15bf240edd313611750bcff9db8a8abca/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5b0916e398084310ba1ffca7859361f9e84e7fb commit c5b0916e398084310ba1ffca7859361f9e84e7fb Author: Tsuyoshi Horo <horo@chromium.org> Date: Wed Oct 25 17:11:12 2017 S13nSW: Implement SWURLTrackingRequestHandler::MaybeCreateLoader DevTools LayoutTests (service-workers-bypass-for-network-navigation.html and service-workers-bypass-for-network-redirect.html) are crashing because ServiceWorkerURLTrackingRequestHandler which is used for skipping service worker doesn't implement MaybeCreateLoader(). Bug: 778220 Change-Id: Ia1b5a7a359858f3e8259421750f7bfa2894a8f15 Reviewed-on: https://chromium-review.googlesource.com/737413 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#511495} [modify] https://crrev.com/c5b0916e398084310ba1ffca7859361f9e84e7fb/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/c5b0916e398084310ba1ffca7859361f9e84e7fb/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Oct 26 2017
Fixed by #4. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=service-workers-bypass-for-network
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f975f8b813b9995b8ee5a798401bc5398eea4a2 commit 2f975f8b813b9995b8ee5a798401bc5398eea4a2 Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Oct 27 04:01:10 2017 Gardening: Update service worker NetworkService test expectations - force-refresh-ready.html and force-refresh-registration.html were fixed in r511495. - Since I duped the crbugs already, update the bug numbers so all http/tests/fetch share the same bug. Bug: 778220 , 778721 Change-Id: I77394a9f5d6181388a26a3a0851173320aff8e14 NOTRY: true TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/740924 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#512086} [modify] https://crrev.com/2f975f8b813b9995b8ee5a798401bc5398eea4a2/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by horo@chromium.org
, Oct 25 2017