New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778213 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression :Options under 'see more' tab are missing on Yahoo page.

Reported by pranjali...@etouch.net, Oct 25 2017

Issue description

 Chrome Version:63.0.3239.18 (Official Build) 975787a36cf8dbe16eaf42134aaee20fe9504ba2-refs/branch-heads/3239@{#188}(32/64 bit)

OS:Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6,13.1).

URL:https://in.help.yahoo.com/kb/account

Steps to reproduce:
1)Launch chrome and go to above URL.
2)Now click on 'see more' option and observe.    

Actual Result:Options under 'see more' tab are missing on Yahoo page. 
Expected Result:Options should be visible under see more tab on Yahoo page.

This is Regression issue broken in 'M-63' and below is manual regression range.
Good Build:63.0.3211.0
Bad Build: 63.0.3212.0


Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/c3a3481c4b1b08775b477144d1d2873a2a3d9900..a66cfe5eaf03ad45306671b5567b942cab7a60c2?pretty=fuller&n=10000

Suspect: r500793

Note:Unable to narrow down range using bisect per-revision,hence providing bisect using old script.


 
Expected_Result.png
91.3 KB View Download
Actual_Result.png
154 KB View Download
Expected_result.mp4
338 KB View Download
Actual_result.mp4
509 KB View Download
Labels: ReleaseBlock-Beta
Tagging with blocker label, please undo fi not the case.

Comment 2 by e...@chromium.org, Oct 25 2017

Cc: mor...@stenshorne.net
This is bad but the bisect seems incorrect here, Kojis change only adds a test and doesn't change anything and the only other Blink change is for CSS Grid which the yahoo page isn't using.

Can we re-run the bisect please?

Adding Morten as the page uses multicol to display the options.

Comment 3 by gov...@chromium.org, Oct 25 2017

Cc: candr...@chromium.org cma...@chromium.org
+candrada@ to try to repro on Android.
Cc: aska...@chromium.org
Issue doesn't repro on the mobile version of that page on Android.
This bug seems similar to issue 771300 .
Components: -Blink>Layout Blink>Layout>MultiCol Blink>Paint
Owner: chrishtr@chromium.org
You are probably looking for a change made after 500791 (known good), but no later than 500792 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/d09b058a2fca054098e5bd14385516425766519b..c3a3481c4b1b08775b477144d1d2873a2a3d9900
Cc: pbomm...@chromium.org
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
The blamed patch is different from issue 771300, though I agree they are likely the same cause.

Is this fixed in 63.0.3239.0 or later, that contain the fix for 771300?
This issue is not yet fixed. Might be the same as issue 771300, not
sure yet. The issue in this bug is related to overflow:hidden + border-radius.
Reduced testcase attached.
test.html
208 bytes View Download
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a1ad402c946c211865d9e1b4ee227da7ffdbf70

commit 1a1ad402c946c211865d9e1b4ee227da7ffdbf70
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri Oct 27 21:10:07 2017

Don't apply pagination offset for rounded clips outside of fragmentation.

This was broken by commit c3a3481. Before that commit, PaintLayerClipper
was not asked how to compute a clip *across* a pagination container, instead
stopping at the pagination container. Thus the case being fixed here was
never exhibited.

Bug:  778213 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3c540e31fdf3b77d5a34fbdf08104d0490f9a1ea
Reviewed-on: https://chromium-review.googlesource.com/740379
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512284}
[add] https://crrev.com/1a1ad402c946c211865d9e1b4ee227da7ffdbf70/third_party/WebKit/LayoutTests/fragmentation/border-radius-clip-above-fragmented-expected.html
[add] https://crrev.com/1a1ad402c946c211865d9e1b4ee227da7ffdbf70/third_party/WebKit/LayoutTests/fragmentation/border-radius-clip-above-fragmented.html
[modify] https://crrev.com/1a1ad402c946c211865d9e1b4ee227da7ffdbf70/third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp
[modify] https://crrev.com/1a1ad402c946c211865d9e1b4ee227da7ffdbf70/third_party/WebKit/Source/core/paint/LayerClipRecorder.h

Labels: Merge-Request-63
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 28 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Before we approve merge to M63, please provide following details:

Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge?

Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux (14.04 LTS) OS using latest Canary #64.0.3253.0 and issue seems fixed. Kindly review an attached screencast.
Actual_Result.mp4
379 KB View Download
Labels: TE-Verified-M64 TE-Verified-64.0.3253.0
[Bulk Edit]
URGENT - PTAL.
M63 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Thank you.

Comment 20 Deleted

Re comment 16: yes this is baked in canary now, and has testing.
Labels: -Merge-Review-63 Merge-Approved-63
Approving merge to M63 branch 3239 based on comment #17 and #21. Please merge ASAP so we can pick it up for tomorrow's Beta release. Thank you.
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 31 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdda31f07006eb4c8b3827148dbe5e380cbf0422

commit fdda31f07006eb4c8b3827148dbe5e380cbf0422
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Tue Oct 31 19:11:21 2017

Don't apply pagination offset for rounded clips outside of fragmentation.

This was broken by commit c3a3481. Before that commit, PaintLayerClipper
was not asked how to compute a clip *across* a pagination container, instead
stopping at the pagination container. Thus the case being fixed here was
never exhibited.

TBR=chrishtr@chromium.org

(cherry picked from commit 1a1ad402c946c211865d9e1b4ee227da7ffdbf70)

Bug:  778213 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3c540e31fdf3b77d5a34fbdf08104d0490f9a1ea
Reviewed-on: https://chromium-review.googlesource.com/740379
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#512284}
Reviewed-on: https://chromium-review.googlesource.com/747205
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#320}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[add] https://crrev.com/fdda31f07006eb4c8b3827148dbe5e380cbf0422/third_party/WebKit/LayoutTests/fragmentation/border-radius-clip-above-fragmented-expected.html
[add] https://crrev.com/fdda31f07006eb4c8b3827148dbe5e380cbf0422/third_party/WebKit/LayoutTests/fragmentation/border-radius-clip-above-fragmented.html
[modify] https://crrev.com/fdda31f07006eb4c8b3827148dbe5e380cbf0422/third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp
[modify] https://crrev.com/fdda31f07006eb4c8b3827148dbe5e380cbf0422/third_party/WebKit/Source/core/paint/LayerClipRecorder.h

Status: Fixed (was: Assigned)
Cc: -mor...@stenshorne.net mstensho@chromium.org

Sign in to add a comment