Non-Regression : Tab Focus is not seen properly for 'Expand/Collapse Notification' Icon |
||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1)Sign into User -> Save any Page or Download any PDF file (2)Now press 'Tab' button and observe Focus on 'Expand/Collapse notification' Icon (Please refer screenshot) Expected: Tab Focus should be seen properly on 'Expand/Collapse Notification' Icon at 'now' text Actual: Instead Tab Focus is not seen properly for 'Expand/Collapse Notification' Icon This is Non-Regression Issue as 'Expand/Collapse Notification' Icon is seen from M-62 @Yoshiki: Please confirm the Issue Note: Issue is also seen on latest M-64
,
Oct 26 2017
Confirmed the issue.
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45c31c31b68a759fde3f2693ea27a23060979938 commit 45c31c31b68a759fde3f2693ea27a23060979938 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Oct 27 05:08:34 2017 Fix notification focus painter related bugs. This CL fixes these focus painter related bugs of notification: - Focus painter for the expand button was not rendered correctly. ( https://crbug.com/778208 ) - Expand button wasn't rendered initially, because NotificationHeaderView::Layout() wasn't called after NotificationHeaderView::SetExpandButtonEnabled() update. - Focus painter for the entire notification was not rendered correctly, due to recent shadow removal (https://crrev.com/c/722303). Related bug: https://crrev.com/c/737690 TEST=manual BUG= 778208 Change-Id: Ieeeb3a8b4bf3df0fda32b7c237ba78d942ab6b5a Reviewed-on: https://chromium-review.googlesource.com/737503 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#512093} [modify] https://crrev.com/45c31c31b68a759fde3f2693ea27a23060979938/ui/message_center/views/message_view.cc [modify] https://crrev.com/45c31c31b68a759fde3f2693ea27a23060979938/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/45c31c31b68a759fde3f2693ea27a23060979938/ui/message_center/views/notification_view_md.cc
,
Oct 27 2017
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfe3e95265b044c73b87c38fcd503ccd043bfebe commit dfe3e95265b044c73b87c38fcd503ccd043bfebe Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Nov 17 06:25:33 2017 Fix notification focus painter related bugs. This CL fixes these focus painter related bugs of notification: - Focus painter for the expand button was not rendered correctly. ( https://crbug.com/778208 ) - Expand button wasn't rendered initially, because NotificationHeaderView::Layout() wasn't called after NotificationHeaderView::SetExpandButtonEnabled() update. - Focus painter for the entire notification was not rendered correctly, due to recent shadow removal (https://crrev.com/c/722303). Related bug: https://crrev.com/c/737690 TEST=manual BUG= 778208 (cherry picked from commit 45c31c31b68a759fde3f2693ea27a23060979938) Change-Id: Ieeeb3a8b4bf3df0fda32b7c237ba78d942ab6b5a Reviewed-on: https://chromium-review.googlesource.com/737503 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#512093} Reviewed-on: https://chromium-review.googlesource.com/776474 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#526} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/dfe3e95265b044c73b87c38fcd503ccd043bfebe/ui/message_center/views/message_view.cc [modify] https://crrev.com/dfe3e95265b044c73b87c38fcd503ccd043bfebe/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/dfe3e95265b044c73b87c38fcd503ccd043bfebe/ui/message_center/views/notification_view_md.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by yoshiki@chromium.org
, Oct 26 2017Owner: tetsui@chromium.org