Each time moving svg path cross drop shadow SVG filter effect it generates line glitches
Reported by
kirillbu...@gmail.com,
Oct 25 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36 Steps to reproduce the problem: 1. Create two svg paths 2. Assign drop-shadow svg filter to bottom one 3. Move other one above filter effect and look at line glitches it generates each time he cross filter effect What is the expected behavior? Translate animation over object with svg drop shadow filter doesn't cause any glitches What went wrong? Each time any object above filtered one cross filter effect it generates glitched lines: http://jsfiddle.net/skgv5nkd/14/ Did this work before? N/A Does this work in other browsers? Yes Chrome version: 62.0.3202.62 Channel: stable OS Version: 10.0 Flash Version:
,
Oct 25 2017
Reduced a bit: http://jsfiddle.net/h1d7pdrz/ Looks like the fractional <feOffset> could be the cause.
,
Oct 25 2017
Truncating the deltas (on the Blink-side) before passing them to SkOffsetImageFilter seems to make the problem go away as well, so possibly something in Skia.
,
Oct 25 2017
,
Oct 26 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/b87f798e5a629284cc008b4986bb2ddba7ed9cb1 commit b87f798e5a629284cc008b4986bb2ddba7ed9cb1 Author: Fredrik Söderquist <fs@opera.com> Date: Thu Oct 26 13:10:07 2017 Consistently round fOffset in SkOffsetImageFilter Since SkScalarRoundToInt rounds differently depending on the sign of the value, care must be taken to perform rounding before any potential change to the sign - like in SkOffsetImageFilter::onFilterNodeBounds. Bug: chromium:778204 Change-Id: I3debff7565f45022c7b8566662927149850b1bea Reviewed-on: https://skia-review.googlesource.com/64020 Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/b87f798e5a629284cc008b4986bb2ddba7ed9cb1/src/effects/SkOffsetImageFilter.cpp [modify] https://crrev.com/b87f798e5a629284cc008b4986bb2ddba7ed9cb1/tests/ImageFilterTest.cpp
,
Oct 26 2017
Who's handling layout test failures? https://storage.googleapis.com/chromium-layout-test-archives/linux_trusty_blink_rel/17745/layout-test-results/results.html
,
Oct 26 2017
On it.
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/892eb33e496fbe71063a9d88d4d3907fee809d27 commit 892eb33e496fbe71063a9d88d4d3907fee809d27 Author: Fredrik Söderquist <fs@opera.com> Date: Thu Oct 26 15:52:17 2017 Temporarily suppress some feOffset tests The following tests * svg/W3C-SVG-1.1/filters-offset-01-b.svg * svg/filters/feOffset.svg show small differences (obvious progression for the former.) TBR=mtklein@chromium.org NOTRY=true Bug: 778204 Change-Id: I3b7e8da7856181f920d7889d5f7ac21c764f1071 Reviewed-on: https://chromium-review.googlesource.com/739484 Reviewed-by: Fredrik Söderquist <fs@opera.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#511829} [modify] https://crrev.com/892eb33e496fbe71063a9d88d4d3907fee809d27/third_party/WebKit/LayoutTests/TestExpectations
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/463c012ab29ae60e519e1991cbb63c12629bdb93 commit 463c012ab29ae60e519e1991cbb63c12629bdb93 Author: Fredrik Söderquist <fs@opera.com> Date: Fri Oct 27 13:09:07 2017 Update baselines after Skia SkOffsetImageFilter change TBR=mtklein@chromium.org,senorblanco@chromium.org Bug: 778204 Change-Id: I7e531d55d2e8c3daf19ed93226c21d9698037d05 Reviewed-on: https://chromium-review.googlesource.com/741233 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#512162} [modify] https://crrev.com/463c012ab29ae60e519e1991cbb63c12629bdb93/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/463c012ab29ae60e519e1991cbb63c12629bdb93/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png [modify] https://crrev.com/463c012ab29ae60e519e1991cbb63c12629bdb93/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png [modify] https://crrev.com/463c012ab29ae60e519e1991cbb63c12629bdb93/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png [modify] https://crrev.com/463c012ab29ae60e519e1991cbb63c12629bdb93/third_party/WebKit/LayoutTests/svg/filters/feOffset-expected.png
,
Oct 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by f...@opera.com
, Oct 25 2017Labels: OS-Linux
Status: Available (was: Unconfirmed)