Issue metadata
Sign in to add a comment
|
Regression: Content of chrome://welcome page is not equally symmetrical from both the end.
Reported by
dchau...@etouch.net,
Oct 25 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3239.18 (Official Build) 975787a36cf8dbe16eaf42134aaee20fe9504ba2-refs/branch-heads/3239@{#188} 32/64-bit. OS: Windows (7,8,10). What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://welcome page. 2. Resize the browser to it's extreme left and observe the content of page. Space/margin doesn't seen between LHS border of browser and LHS content of page. Space/margin should be seen between LHS border of browser and LHS content of page. This is a regression issue, broken in M-59 series, below is manual regression range. Good build: 59.0.3041.0 Bad build: 59.0.3042.0 You are probably looking for a change made after 456866 (known good), but no later than 456867 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/d7352d575439e19379d378a9e29ac8cc5b0c8a72..939b97d2936323c01181ddabe38a4e3780da242c Suspect: https://chromium.googlesource.com/chromium/src/+/939b97d2936323c01181ddabe38a4e3780da242c @huangs: Kindly help to reassign if your changes are not related to this issue. Note: This issue is not seen on Mac and Linux OS. Kindly review the attached screen-cast for reference.
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ab1c120117dfce25fabdda45d5dc5ec2b6cff98 commit 6ab1c120117dfce25fabdda45d5dc5ec2b6cff98 Author: huangs <huangs@google.com> Date: Mon Apr 09 18:24:12 2018 [FRE] Fix margin regression. https://codereview.chromium.org/2750673006 sets margin to 0 for <body> in chrome://welcome to prevent vertical scroll bar from always showing, but as a result, makes text look poor when window is shrunken. This CL augments the old fix with padding and box-sizing, to solve both problems. Bug: 778202 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9480799be706e58fb27884f178b2652094a39394 Reviewed-on: https://chromium-review.googlesource.com/996856 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#549229} [modify] https://crrev.com/6ab1c120117dfce25fabdda45d5dc5ec2b6cff98/chrome/browser/resources/welcome/welcome.css
,
Apr 9 2018
,
Apr 10 2018
Update : Retested This issue on Windows(7,8,10) machines using latest Canary build #67.0.3393.0 (64-bit) and issue is fixed. Note: Will soon update the behavior of Windows build #67.0.3393.0 (32-bit) once build will be triggered. Kindly review the attached screen-cast for reference. Thank you!
,
Apr 11 2018
Update : Retested This issue on Windows(7,8,10) machines using Dev build #67.0.3393.4 (32/64-bit) and issue is fixed. Hence adding TE-Verified labels using Dev build. Kindly review the attached screen-cast for reference. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by hua...@chromium.org
, Apr 5 2018