New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778188 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 778689
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Sketchfab: hard crash

Reported by p...@sketchfab.com, Oct 25 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36

Example URL:
 We also get webgl hard crash -  https://sketchfab.com/models/0782d9f75d794e86b14614e58a3095f0 click on model inspector ()

Steps to reproduce the problem:
1. go to https://sketchfab.com/models/3d87a02b064b48c68262314ceffb19fd
2. open "model inspector" the "multiple planes" icon on the right bottom of the viewer
3. scroll on new black "model inspector" menu on the left side to the "UV Checker" button and click on it
4 webgl hard crash

What is the expected behavior?
it should just display uv on mesh

What went wrong?
hard webgl crash (no restore possible)

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? Yes 61

Does this work in other browsers? Yes

Chrome version: 62.0.3202.62  Channel: stable
OS Version: 10.0
Flash Version: 

used to work fine until chrome 62 on windows 10
(works on all other os/browser)
 
Components: Blink>WebGL Internals>GPU
Labels: Needs-Bisect Needs-Triage-M62
Labels: -Type-Compat Type-Bug-Regression
Status: Available (was: Unconfirmed)
Able to repro on Win10/Intel.
https://crash.corp.google.com/139662d68cb23725

0x00007ff8a7490430	(libglesv2.dll -inputlayoutcache.cpp:404 )	rx::InputLayoutCache::createInputLayout(rx::Renderer11 *,std::array<int,16> const &,std::vector<rx::TranslatedAttribute const *,std::allocator<rx::TranslatedAttribute const *> > const &,unsigned int,gl::Program *,int,rx::Resource11<ID3D11InputLayout> *)
0x00007ff8a74902b1	(libglesv2.dll -inputlayoutcache.cpp:366 )	rx::InputLayoutCache::updateInputLayout(rx::Renderer11 *,gl::State const &,std::vector<rx::TranslatedAttribute const *,std::allocator<rx::TranslatedAttribute const *> > const &,unsigned int,std::array<int,16> const &,int)
0x00007ff8a7445a10	(libglesv2.dll -statemanager11.cpp:1962 )	rx::StateManager11::applyVertexBuffer(gl::Context const *,unsigned int,int,int,int,rx::TranslatedIndexData *)
0x00007ff8a73bf627	(libglesv2.dll -renderer11.cpp:1763 )	rx::Renderer11::drawElementsImpl(gl::Context const *,unsigned int,int,unsigned int,void const *,int)
0x00007ff8a73c7697	(libglesv2.dll -renderer11.cpp:4177 )	rx::Renderer11::genericDrawElements(gl::Context const *,unsigned int,int,unsigned int,void const *,int)
0x00007ff8a74480d3	(libglesv2.dll -context11.cpp:174 )	rx::Context11::drawElements(gl::Context const *,unsigned int,int,unsigned int,void const *)
0x00007ff8a7338e57	(libglesv2.dll -context.cpp:1765 )	gl::Context::drawElements(unsigned int,int,unsigned int,void const *)
0x00007ff8a7313726	(libglesv2.dll -entry_points_gles_2_0_autogen.cpp:767 )	gl::DrawElements(unsigned int,int,unsigned int,void const *)
0x00007ff89f8dc02d	(chrome_child.dll -gl_gl_api_implementation.cc:442 )	gl::RealGLApi::glDrawElementsFn(unsigned int,int,unsigned int,void const *)
0x00007ff8a03409b5	(chrome_child.dll -gles2_cmd_decoder.cc:10544 )	gpu::gles2::GLES2DecoderImpl::DoDrawElements(char const *,bool,unsigned int,int,unsigned int,int,int)
0x00007ff8a034ef52	(chrome_child.dll -gles2_cmd_decoder.cc:10580 )	gpu::gles2::GLES2DecoderImpl::HandleDrawElements(unsigned int,void const volatile *)
0x00007ff8a0331911	(chrome_child.dll -gles2_cmd_decoder.cc:5378 )	gpu::gles2::GLES2DecoderImpl::DoCommandsImpl<0>(unsigned int,void const volatile *,int,int *)
0x00007ff8a033c1fa	(chrome_child.dll -gles2_cmd_decoder.cc:5429 )	gpu::gles2::GLES2DecoderImpl::DoCommands(unsigned int,void const volatile *,int,int *)

Components: Internals>GPU>ANGLE
Owner: jmad...@chromium.org
Status: Assigned (was: Available)
The crash is in ANGLE; the lower parts are most recently changed by jmadill. Jamie, can you take a look?
Actually, it doesn't seem to repro in Canary, so this is probably a dupe of something.
Thanks for the tips. I can look into it, I don't off the top of my head recall what fix it might be.
Well, if we're pretty sure it's fixed we can probably mark as wontfix. I only tested it once with Canary though.
It seems to work for me in Canary as well. We could try doing a bisect. Not sure what's the best action.
Labels: -Needs-Triage-M62 M-62
If it's still broken in 63, we probably want to find the commit that fixed it and see if it's small enough to merge to 63.
Cc: vamshi.k...@techmahindra.com
Labels: Triaged-ET Needs-Triage-M62 Needs-Feedback
Unable to reproduce the issue on reported version 62.0.3202.62 and Latest Canary 64.0.3250.0 using Windows 10 with the following steps

1. Opened Chrome
2. Navigated to https://sketchfab.com/models/3d87a02b064b48c68262314ceffb19fd
3. Clicked on model inspector.
4. Scrolled down to the bottom and clicked "UV Checker".
We observed the UV on mesh displayed properly with out any crash. Attaching the screen cast of hte same.

@Reporter: Please check the screen cast and we are looking forward for any further inputs from your end in reproducing the issue.

Thanks!
778188.mp4
2.5 MB View Download

Comment 10 by p...@sketchfab.com, Oct 26 2017

We just shipped a fix for it on our side so that crash doesn't happen.

We had VAO enabled when drawing a non VAO geom, which leads to those hard crash.

Comment 11 by p...@sketchfab.com, Oct 26 2017

This bug can be closed, sorry.
Paul, do you know what that means in terms of GL calls when you say "VAO enabled when drawing to a non VAO geom"? I'm not sure if you're using three.js or other support libraries.

Comment 13 by p...@sketchfab.com, Oct 26 2017

we use osgjs, the fix is there: https://github.com/cedricpinson/osgjs/commit/
cd3737da30daeb63471129edea8009644bc7c60e

More details from commit message: "When using Morph geometry with BufferProxy the geometry does not use vao
so when we had something like:
Geometry VAO
Geomtry Non-VAO
The second geometry was changing the VAO of the first geometry. The fix
disable VAO when drawing the second geometry."

Comment 14 by p...@sketchfab.com, Oct 26 2017

retrying the link seems it was split in two:
https://github.com/cedricpinson/osgjs/commit/cd3737da30daeb63471129edea8009644bc7c60e
Mergedinto: 778689
Status: Duplicate (was: Assigned)
Going to merge this into another report, since that report has information that might make triage easier. Thanks paul@sketchfab.com for your original report.

Sign in to add a comment