New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778175 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Xoogler
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

14.2% regression in blink_perf.shadow_dom at 510669:510708

Project Member Reported by kraynov@chromium.org, Oct 25 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 25 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=778175

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=19033e61eeda6648003ce027804148ec7f0e8213dc5eb35817addb33fad09403


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 25 2017

Cc: sadrul@chromium.org
Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author sadrul@chromium.org ===

Hi sadrul@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Sadrul Habib Chowdhury
  Commit : 01dec7d4e645fc8a6673d6c7fc7c9735fa10aac9
  Date   : Sat Oct 21 18:35:48 2017
  Subject: viz: Move all SoftwareOutputDevice into viz.

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : blink_perf.shadow_dom
  Metric       : v1-distribution-disconnected-and-reconnected/v1-distribution-disconnected-and-reconnected
  Change       : 0.75% | 33.3983333333 -> 33.149

Revision             Result                   N
chromium@510668      33.3983 +- 0.110442      6      good
chromium@510688      33.417 +- 0.105906       6      good
chromium@510689      33.6158 +- 0.164975      6      good
chromium@510690      33.164 +- 0.234312       6      bad       <--
chromium@510691      33.1552 +- 0.155906      6      bad
chromium@510693      33.208 +- 0.156888       6      bad
chromium@510698      33.131 +- 0.283196       6      bad
chromium@510708      33.149 +- 0.156301       6      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.shadow_dom

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964768339259065472


For feedback, file a bug with component Speed>Bisection

Comment 4 by sadrul@chromium.org, Oct 25 2017

Owner: kraynov@chromium.org
That particular CL should not affect blink. (it's a file move of code blink does not even directly use).

Sending back for triage.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 25 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : blink_perf.shadow_dom
  Metric       : v1-distribution-disconnected-and-reconnected/v1-distribution-disconnected-and-reconnected

Revision             Result                  N
chromium@510668      35.917 +- 12.1395       21      good
chromium@510708      36.0207 +- 12.6247      21      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.shadow_dom

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964752152430359696


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Assigned)

Sign in to add a comment