New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 778174 link

Starred by 1 user
Status: Fixed
Owner:
sprang@chromium.org
Closed: Oct 2017
Cc:
█ philipel@chromium.org
mflodman@chromium.org
sprang@chromium.org
brandtr@chromium.org
terelius@chromium.org
holmer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Merge WebRTC r14603 to M63

Project Member Reported by sprang@chromium.org, Oct 25 2017 
There's a bug in the setup of bandwidth estimation for WebRTC, causing  degradation of experience if send-side estimation is not enabled.

This trivial fix should be merged to M63 so that we are able to roll out performance improvements to screensharing in a timely manner.

Fix was landed in WebRTC here:
https://webrtc.googlesource.com/src/+/7c8cca3dce75cf60c8816fc962b0b44dc4444ed8
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 26 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by sprang@chromium.org, Oct 26 2017

Labels: -Merge-Approved-63 merge-merged-63
Status: Fixed (was: Started)
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/e8eedcd7e5da7a7dcdecd49db3e3ff62ab724f86

commit e8eedcd7e5da7a7dcdecd49db3e3ff62ab724f86
Author: Erik Språng <sprang@webrtc.org>
Date: Thu Oct 26 11:31:32 2017

Add check for send-side bwe before applying alr settings

This meges r20423 to M63 branch.
Previously revied at https://webrtc-review.googlesource.com/14603
Merge request at  crbug.com/778174 

Bug: webrtc:7694
Change-Id: Ib754f4342cec14d21a1bc1cfec2df466932a0e20
Reviewed-on: https://webrtc-review.googlesource.com/15324
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/branch-heads/63@{#8}
Cr-Branched-From: bef8a5d2ca5413c680995584b8c0976852ba5f25-refs/heads/master@{#20237}
[modify] https://crrev.com/e8eedcd7e5da7a7dcdecd49db3e3ff62ab724f86/modules/pacing/paced_sender.cc
[modify] https://crrev.com/e8eedcd7e5da7a7dcdecd49db3e3ff62ab724f86/modules/pacing/paced_sender.h
[modify] https://crrev.com/e8eedcd7e5da7a7dcdecd49db3e3ff62ab724f86/video/video_send_stream.cc
[modify] https://crrev.com/e8eedcd7e5da7a7dcdecd49db3e3ff62ab724f86/video/video_send_stream_tests.cc
►

Sign in to add a comment