New issue
Advanced search Search tips

Issue 778168 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Scroll-to-fetch-more stops working when CH is closed

Project Member Reported by bauerb@chromium.org, Oct 25 2017

Issue description

Version: 63.0.3139.10
Steps to reproduces:
1) Start Chrome fresh
2) Open Chrome Home
3) Scroll to the bottom of the suggestion list. Note that a spinner appears and more suggestions are fetched.
4) Close Chrome Home
5) Re-open Chrome Home and scroll to the bottom of the suggestion list again

Expected: the spinner should appear again and more suggestions should be fetched
Actual: a "more" button is shown.
 

Comment 1 by bauerb@chromium.org, Oct 25 2017

(Also, note that this is with the ChromeHomeDestroySuggestions feature *off*.)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a608b567d95eebb450a41e45f7edf88a60a44c26

commit a608b567d95eebb450a41e45f7edf88a60a44c26
Author: Peter E Conn <peconn@chromium.org>
Date: Wed Oct 25 14:50:05 2017

🏡 Clear RecyclerView from NewTabPageAdapter when detached.

I failed to reset mRecyclerView when I added onDetachedFromRecyclerView,
causing the bug.

Bug:  778168 
Change-Id: I2a90bd8d43c36b3f22addddec85ceeebb749c28c
Reviewed-on: https://chromium-review.googlesource.com/738194
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511455}
[modify] https://crrev.com/a608b567d95eebb450a41e45f7edf88a60a44c26/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Comment 3 by peconn@chromium.org, Oct 25 2017

Status: Fixed (was: Assigned)

Sign in to add a comment