New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778158 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Glimpse of toggle button is seen momentarily on 'Edit person' subpage.

Reported by avsha...@etouch.net, Oct 25 2017

Issue description

Chrome version : 64.0.3249.0 (Official Build) 541b864f7aa3820604ad0a8d692d975bab4c2600-refs/heads/master@{#511318} 32/64 bit
OS : Windows(7,8,10), Linux(14.04 LTS), Mac(10.12.6)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings page and enable 'Show home button' toggle button.
2. Click on 'Person name' row and observe glimpse of toggle button at the bottom of 'Edit person' subpage.

Actual Result : Glimpse of toggle button is seen momentarily on 'Edit person' subpage.

Expected Result : Glimpse of toggle button should not be seen on another subpage.

This is a regression issue broken in ‘M-64’ and using the per-revision bisect providing the bisect results,
Good build : 64.0.3240.0 (Revision : 508893)
Bad build : 64.0.3241.0 (Revision : 508934)

You are probably looking for a change made after 508918 (known good), but no later than 508919 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/e0d7ed61b45554d5511a0e19d9ed69ed3717ac98..f423bc1ae49988cc5be11c16fd7fd137b84da587

Suspect : https://chromium.googlesource.com/chromium/src/+/f423bc1ae49988cc5be11c16fd7fd137b84da587

@dpapad : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank you.
 
Actual_Result.mov
8.3 MB Download
Expected_Result.mov
7.5 MB Download
Actual_Result.png
65.7 KB View Download
Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.

Comment 2 by dpa...@chromium.org, Oct 25 2017

Status: Started (was: Assigned)
I am able to reproduce this. Investigating...
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ade6d7573a1341a0cf022f3f913e6acb772a8ae6

commit ade6d7573a1341a0cf022f3f913e6acb772a8ae6
Author: dpapad <dpapad@chromium.org>
Date: Thu Oct 26 17:59:40 2017

WebUI cr-toggle: Fix stacking context with z-index.

cr-toggle was not creating a new stacking context, which ended
up causing parts of it erroneously rendering on top of other elements.

Bug:  778158 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1299781d40fd0dc8b66744bb0a2be9335fe6c017
Reviewed-on: https://chromium-review.googlesource.com/737486
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511877}
[modify] https://crrev.com/ade6d7573a1341a0cf022f3f913e6acb772a8ae6/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html

Comment 4 by dpa...@chromium.org, Oct 26 2017

Status: Fixed (was: Started)

Comment 5 by avsha...@etouch.net, Oct 27 2017

Labels: TE-Verified-M64 TE-Verified-64.0.3251.0
Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux (14.04 LTS) OS using latest Dev #64.0.3251.0 build and issue seems fixed. Kindly review an attached screen-cast.

Thank you!
Dev_behavior.mp4
576 KB View Download

Sign in to add a comment