New issue
Advanced search Search tips

Issue 778148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 715640



Sign in to add a comment

ServiceWorkerSubresourceLoader leaks when fetch event has been aborted

Project Member Reported by shimazu@chromium.org, Oct 25 2017

Issue description

Currently when fetch event has been aborted, subresource loader invalidates all weak pointer. It also invalidates an error callback set to the mojo binding, and it results that subresource loader fails to delete itself.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4051b64f4e700bc168ff667d112d5c87fa6d37b

commit f4051b64f4e700bc168ff667d112d5c87fa6d37b
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Thu Oct 26 01:33:27 2017

S13nServiceWorker: Fix a leak in subresource loader when aborting

Currently a subresource loader could be leaked if a fetch event is aborted
because it invalidated the weak pointers to it and it results invalidating the
error callback. This patch is fixing it by removing invalidation and binding the
error callback with base::Unretained().

Bug:  778148 
Change-Id: I6c6288922203f3d0b2f2379309c540540b0f0ca4
Reviewed-on: https://chromium-review.googlesource.com/737949
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511684}
[modify] https://crrev.com/f4051b64f4e700bc168ff667d112d5c87fa6d37b/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/f4051b64f4e700bc168ff667d112d5c87fa6d37b/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc

Comment 2 by falken@chromium.org, Oct 27 2017

Blocking: 715640
Status: Fixed (was: Started)

Comment 4 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 5 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment