The PasswordManagerPresenter seems to contain some dead code, relics of its use in the old settings page. It might also need some clarification of what is used on Android and more improvements for better testability.
This bug tracks those changes made in order to prepare the full launch of import/export of passwords.
Turns out the GetPassword* methods I suspected from being dead are still used on Android.
So my next step is to understand, how the presenter is used by desktop settings view, Android settings view and how could it possibly be used by iOS settings view, and try to redesign all those different usage patterns to be more similar. As a result, PMPresenter could become smaller and contain less #ifdefs.
Cc: vabr@chromium.org Owner: ---- Status: Available (was: Assigned)
I don't expect to have time to look into this soon.
Having said that, if I find time to do contributions to Chromium, this is on top of my list at the moment.
Comment 1 by vabr@chromium.org
, Oct 25 2017