New issue
Advanced search Search tips

Issue 778139 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Window close event is not recorded in SuggestApps dialog histogram

Project Member Reported by yamaguchi@chromium.org, Oct 25 2017

Issue description

Chrome Version: 64.0.3249.0

We added histogram for suggest apps dialog ( Issue 307342 ) but the close-dialog event is not recorded correctly.
 
Summary: Window close event is not recorded in SuggestApps dialog histogram (was: Issue 307342)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8a6fd5abbbdb8471f49672b7ea71caa378328aa

commit b8a6fd5abbbdb8471f49672b7ea71caa378328aa
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Thu Oct 26 03:39:07 2017

Correct the name of the histogram to match with the reference from js.

The name should match with the one in CwsWidgetContainer.
The metric was originally added by https://codereview.chromium.org/27301002

Bug:  778139 
Test: manually verified in chrome:histograms
Change-Id: Ib8dc621f95e1abd92630f9a004b6601d69cf620f
Reviewed-on: https://chromium-review.googlesource.com/737410
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511730}
[modify] https://crrev.com/b8a6fd5abbbdb8471f49672b7ea71caa378328aa/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Unconfirmed)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment