Issue metadata
Sign in to add a comment
|
S13nSW: ServiceWorkerSubresourceLoader should wait for the stream to finish before completing |
||||||||||||||||||||||
Issue descriptionThis is similar issue to issue 758455 . Currently we are immediately completing the resource request which has stream response when the response header comes in. We need to implement simplar mechanism to the SWURLLoaderJob to wait until the end of streaming.
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11c80827bb9e25776c5e40b0a9ccee271e503d92 commit 11c80827bb9e25776c5e40b0a9ccee271e503d92 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Feb 16 02:55:59 2018 S13nSW: Introduce ServiceWorkerSubresourceLoader::StreamWaiter We should delay completing a resource request until all data has been received. Before this CL, we completed a request immediately after the response header comes in. To delay completing requests this CL introduces ServiceWorkerSubresourceLoader::StreamWaiter, which is similar to ServiceWorkerURLLoaderJob::StreamWaiter. It completes a request after OnCompleted() callback is called (or OnAborted() is called). This CL also fixes some typos. Bug: 778110 Change-Id: I6f3292eeb483b83e74f0d0be1df8b5e555e8c8f5 Reviewed-on: https://chromium-review.googlesource.com/920045 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#537153} [modify] https://crrev.com/11c80827bb9e25776c5e40b0a9ccee271e503d92/content/browser/service_worker/service_worker_url_loader_job.cc [modify] https://crrev.com/11c80827bb9e25776c5e40b0a9ccee271e503d92/content/renderer/service_worker/service_worker_subresource_loader.cc [modify] https://crrev.com/11c80827bb9e25776c5e40b0a9ccee271e503d92/content/renderer/service_worker/service_worker_subresource_loader.h [modify] https://crrev.com/11c80827bb9e25776c5e40b0a9ccee271e503d92/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
,
Feb 16 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by laforge@google.com
, Nov 7 2017