New issue
Advanced search Search tips

Issue 778095 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.multitab:misc:typical24 failing on Win 7

Project Member Reported by nedngu...@google.com, Oct 25 2017

Issue description

Log:
https://chromium-swarm.appspot.com/task?id=3969f6e4190d5310&refresh=10&show_raw=1

  Traceback (most recent call last):
    RunBenchmark at e:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py:334
      max_num_values=benchmark.MAX_NUM_VALUES)
    Run at e:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py:202
      _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
    _RunStoryAndProcessErrorIfNeeded at e:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py:106
      test.Measure(state.platform, results)
    Measure at e:\b\s\w\ir\third_party\catapult\telemetry\telemetry\web_perf\timeline_based_measurement.py:290
      self._ComputeTimelineBasedMetrics(results, trace_value)
    _ComputeTimelineBasedMetrics at e:\b\s\w\ir\third_party\catapult\telemetry\telemetry\web_perf\timeline_based_measurement.py:335
      results.histograms.ImportDicts(mre_result.pairs.get('histograms', []))
    ImportDicts at e:\b\s\w\ir\third_party\catapult\tracing\tracing\value\histogram_set.py:82
      self.AddHistogram(histogram_module.Histogram.FromDict(d))
    FromDict at e:\b\s\w\ir\third_party\catapult\tracing\tracing\value\histogram.py:1024
      hist._bins[int(i)].FromDict(bin_dct)
    FromDict at e:\b\s\w\ir\third_party\catapult\tracing\tracing\value\histogram.py:855
      diagnostic_map_dict))
    FromDict at e:\b\s\w\ir\third_party\catapult\tracing\tracing\value\histogram.py:770
      dm.AddDicts(dct)
    AddDicts at e:\b\s\w\ir\third_party\catapult\tracing\tracing\value\histogram.py:778
      self[name] = diagnostic.Diagnostic.FromDict(diagnostic_dict)
    FromDict at e:\b\s\w\ir\third_party\catapult\tracing\tracing\value\diagnostics\diagnostic.py:49
      diagnostic = cls.FromDict(dct)
    FromDict at e:\b\s\w\ir\third_party\catapult\tracing\tracing\value\histogram.py:352
      result.Set(name, value)
    Set at e:\b\s\w\ir\third_party\catapult\tracing\tracing\value\histogram.py:375
      assert isinstance(value, (int, float))
  AssertionError
  
  Locals:
    name  : u'system_memory'
    value : 2562735712L
  
  Traceback (most recent call last):
    File "e:\b\s\w\ir\tools\perf\benchmarks\system_health_smoke_test.py", line 118, in RunTest
      msg='Failed: %s' % benchmark_class)
  AssertionError: Failed: <class 'benchmarks.system_health.DesktopMemorySystemHealth'>

Retrying failed tests (attempt #1 of 3)...

 
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b6c61b2c1fb9954102206c6cc81425a8a6291d4

commit 5b6c61b2c1fb9954102206c6cc81425a8a6291d4
Author: Ned Nguyen <nednguyen@google.com>
Date: Wed Oct 25 04:09:47 2017

Disable system_health.memory_desktop.multitab:misc:typical24

TBR=benjhayden@chromium.org

Bug:  778095 
Change-Id: Icdbd9d1dc62b5367a80a25e2838a7fe31c9894cb
Reviewed-on: https://chromium-review.googlesource.com/737329
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#511364}
[modify] https://crrev.com/5b6c61b2c1fb9954102206c6cc81425a8a6291d4/tools/perf/benchmarks/system_health_smoke_test.py

Cc: benjhayden@chromium.org
Owner: nedngu...@google.com
The fix has been merged to catapult. How do I re-enable the auto roller?
https://chromium-review.googlesource.com/c/catapult/+/730856

Cc: -benjhayden@chromium.org nedngu...@google.com
Owner: benjhayden@chromium.org
I enabled auto roller a while ago (see catapult-roll.skia.org). So can you revert the change in #2 & watch this test?
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abda68dcbd3f77140c2ce10dcf3912aa73501889

commit abda68dcbd3f77140c2ce10dcf3912aa73501889
Author: Ben Hayden <benjhayden@chromium.org>
Date: Tue Oct 31 01:54:25 2017

Re-enable some tests in system_health_smoke_test.

A bug in catapult caused these tests to fail. That bug was fixed:
https://chromium-review.googlesource.com/c/catapult/+/730856

Bug:  chromium:778169 ,  chromium:778095 , chromium:776608
Change-Id: Ieed45163b23b3a604efee248e99c2ea14661e744
Reviewed-on: https://chromium-review.googlesource.com/742393
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512712}
[modify] https://crrev.com/abda68dcbd3f77140c2ce10dcf3912aa73501889/tools/perf/benchmarks/system_health_smoke_test.py

Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment