New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 778088 link

Starred by 1 user
Status: Fixed
Owner:
patricia...@chromium.org
Closed: Nov 2017
Cc:
maxwalker@chromium.org
█ raymes@chromium.org
tapted@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Page Info Bubble: Make the combobox widths more consistent for different string lengths.

Project Member Reported by patricia...@chromium.org, Oct 25 2017 
Now that Harmony comboboxes have borders, it's more obvious the permission comboboxes in the page info bubble change to fit the width of the string it contains. This might look weird when there are a lot of permissions with different options selected, so we should make sure the combobox widths are more consistent by making sure the combobox is always sized to a width that will fix the longest string (under a max threshold).

See the possible options by maxwalker@ in the attached screenshot (with option C being the proposed solution).
Slice.png
86.0 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c1aa718068cde37e7960934123a93576b034e82

commit 9c1aa718068cde37e7960934123a93576b034e82
Author: Patti <patricialor@chromium.org>
Date: Wed Nov 01 03:28:41 2017

Desktop Page Info/Harmony: Limit combobox width to a maximum.

Make all page info combobox widths be the same as the longest currently
displayed item, provided it doesn't exceed a max threshold.

Screenshot -
https://drive.google.com/file/d/0BzEa5HU1aAqBc1U4SjdhZnVONzA/view?usp=sharing

Bug:  535074 ,  778088 
Change-Id: I235e51e9b7d8c77eff43c5690c62e4008a411fef
Reviewed-on: https://chromium-review.googlesource.com/730243
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513065}
[modify] https://crrev.com/9c1aa718068cde37e7960934123a93576b034e82/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/9c1aa718068cde37e7960934123a93576b034e82/chrome/browser/ui/views/page_info/permission_selector_row.cc
[modify] https://crrev.com/9c1aa718068cde37e7960934123a93576b034e82/chrome/browser/ui/views/page_info/permission_selector_row.h

Comment 2 by patricia...@chromium.org, Nov 6 2017

Labels: OS-Chrome OS-Windows
Status: Fixed (was: Started)
►

Sign in to add a comment