New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778074 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 753469



Sign in to add a comment

[MD extensions] the side nav looks broken with large fonts

Project Member Reported by dschuyler@chromium.org, Oct 25 2017

Issue description

1) go to chrome://settings/fonts
2) Change font size to something very large
3) go to MD chrome://extensions

Problem: Some menu labels are cut off and unreadable.

 
Blocking: 753469

Comment 3 Deleted

Status: Started (was: Available)
Screenshot from 2017-10-30 14:52:19.png
21.5 KB View Download
Screenshot from 2017-10-30 14:52:37.png
43.7 KB View Download
Screenshot from 2017-10-30 14:53:14.png
50.5 KB View Download
Screenshot from 2017-10-30 14:55:32.png
47.8 KB View Download
Screenshot from 2017-10-30 14:55:49.png
62.6 KB View Download
Screenshot from 2017-10-30 14:56:09.png
38.8 KB View Download
Status: Assigned (was: Started)
Focusing on other bugs right now.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/768e5c0467ef36e6bb969ecb3eb420679ace7732

commit 768e5c0467ef36e6bb969ecb3eb420679ace7732
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Nov 15 04:00:17 2017

[MD extensions] Allow for large font size in side nav

This CL wraps text to allow for large font sizes in the side nav drawer.

Bug:  778074 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia597f0bb5453bba6351de9abbaeb1123591f32f1
Reviewed-on: https://chromium-review.googlesource.com/737064
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516588}
[modify] https://crrev.com/768e5c0467ef36e6bb969ecb3eb420679ace7732/chrome/browser/resources/md_extensions/sidebar.html
[modify] https://crrev.com/768e5c0467ef36e6bb969ecb3eb420679ace7732/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html

Status: Fixed (was: Assigned)
Labels: TE-Verified-64.0.3270.0 TE-Verified-M64
Tested the issue on Windows 7, Mac OS 10.12.6 and Ubuntu 14.04 using chrome version 64.0.3270.0 by following the steps mentioned in the original comment and issue seems to be fixed.

Observed that after changing the font size to huge, the menu labels are not cut off and are readable.
Attaching screen shotfor reference.
Hence adding TE-Verified Labels.

Thanks!
778074.png
35.9 KB View Download

Sign in to add a comment