New issue
Advanced search Search tips

Issue 778055 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

luci-py/client/tests/threading_utils_test.py is flaky

Project Member Reported by mar...@chromium.org, Oct 25 2017

Issue description

tests/threading_utils_test.py (30.76s) failed
(...)
======================================================================
FAIL: test_abort (__main__.ThreadPoolTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/threading_utils_test.py", line 52, in wrapper
    return method(self, *args, **kwargs)
  File "tests/threading_utils_test.py", line 293, in test_abort
    results.extend(pool.join())
  File "/b/s/w/ir/cache/builder/Luci_py_Presubmit/infra/luci/client/utils/threading_utils.py", line 325, in __exit__
    self.close()
  File "/b/s/w/ir/cache/builder/Luci_py_Presubmit/infra/luci/client/utils/threading_utils.py", line 294, in close
    t.join(30)
  File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/threading.py", line 951, in join
    self.__block.wait(delay)
  File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/threading.py", line 359, in wait
    _sleep(delay)
  File "tests/threading_utils_test.py", line 49, in <lambda>
    signal.signal(signal.SIGALRM, lambda *_args: self.fail('Timeout'))
AssertionError: Timeout
----------------------------------------------------------------------
Ran 44 tests in 30.709s

Doesn't happen that often but it's annoying. 30s is from the automatic abort logic, the test case takes 5ms on my laptop.
 
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/6781c2d22ad596733bfdaec023dbd90778804e98

commit 6781c2d22ad596733bfdaec023dbd90778804e98
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Mon Oct 30 21:38:59 2017

Print more information in case of failure

To help diagnose the problem in the unit test.

Bug: 778055
Change-Id: I4b64b911e5341445f437b05ad91c2e0860e1abf8
Reviewed-on: https://chromium-review.googlesource.com/741095
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/6781c2d22ad596733bfdaec023dbd90778804e98/client/tests/threading_utils_test.py

Comment 3 by mar...@chromium.org, Nov 20 2017

Cc: mar...@chromium.org no...@chromium.org d...@chromium.org
 Issue 664649  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/6bb3e67f2017be062217112ae5f97d23732af590

commit 6bb3e67f2017be062217112ae5f97d23732af590
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Thu Dec 07 21:16:47 2017

Disable flaky test in threading_utils_test.py

There's probably a way to fix it but it's not worth the work for now.

R=iannucci@chromium.org
Bug: 778055
Change-Id: I541625a0b07286714603b56f6500a0cee49b0d08
Reviewed-on: https://chromium-review.googlesource.com/815257
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/6bb3e67f2017be062217112ae5f97d23732af590/client/tests/threading_utils_test.py

Cc: -iannucci@chromium.org iannu...@google.com

Sign in to add a comment