UISourceCode having subclasses makes it clunky to work with.
UISourceFrame having subclasses makes it clunky to work with.
Document: https://docs.google.com/a/chromium.org/document/d/1pzUvOg9kWtPWWtKWqf-4mr5x5pt6kAm2cK1A-fLAH0c/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f52baea10fe90f24f52e286bbf424927d4250baa commit f52baea10fe90f24f52e286bbf424927d4250baa Author: Joel Einbinder <einbinder@chromium.org> Date: Tue Oct 31 03:09:39 2017 DevTools: CSSSourceFrame -> CSSPlugin Moves UISourceCodeFrame to sources Introduces UISourceCodeFrame.Plugin Moves CSSSourceFrame from being a subclass to a plugin Bug: 778043 Change-Id: Ia93a4bc2b26ae1a28505d2f82220ad5c21882f0b Reviewed-on: https://chromium-review.googlesource.com/736672 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#512729} [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/LayoutTests/http/tests/devtools/sources/bezier-swatch-position.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/LayoutTests/http/tests/devtools/sources/color-swatch-position.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/source-frame.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/coverage/module.json [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/perf_ui/LineLevelProfile.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/perf_ui/module.json [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/source_frame/module.json [rename] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/sources/CSSPlugin.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js [rename] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js [modify] https://crrev.com/f52baea10fe90f24f52e286bbf424927d4250baa/third_party/WebKit/Source/devtools/front_end/sources/module.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/792e482212d3eace2f24a1975a339bbdc73d1973 commit 792e482212d3eace2f24a1975a339bbdc73d1973 Author: Joel Einbinder <einbinder@chromium.org> Date: Wed Nov 15 22:17:33 2017 DevTools: JavaScriptCompiler -> JavaScriptCompilerPlugin This moves JavaScriptCompiler out of JavaScriptSourceFrame, and converts it to be a UISourceCodeFrame.Plugin. Bug: 778043 Change-Id: I1a0e18748db9247947444a0cd0b8fa9233152cbd Reviewed-on: https://chromium-review.googlesource.com/754511 Reviewed-by: Erik Luo <luoe@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#516854} [modify] https://crrev.com/792e482212d3eace2f24a1975a339bbdc73d1973/third_party/WebKit/LayoutTests/http/tests/devtools/sources/compile-javascript.js [modify] https://crrev.com/792e482212d3eace2f24a1975a339bbdc73d1973/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/792e482212d3eace2f24a1975a339bbdc73d1973/third_party/WebKit/Source/devtools/front_end/sources/CSSPlugin.js [delete] https://crrev.com/16b84d67c1349f534233cecefc332cf94387542a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js [add] https://crrev.com/792e482212d3eace2f24a1975a339bbdc73d1973/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompilerPlugin.js [modify] https://crrev.com/792e482212d3eace2f24a1975a339bbdc73d1973/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js [modify] https://crrev.com/792e482212d3eace2f24a1975a339bbdc73d1973/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js [modify] https://crrev.com/792e482212d3eace2f24a1975a339bbdc73d1973/third_party/WebKit/Source/devtools/front_end/sources/module.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/999f86a928792cce1cb90fcfd7be249e37ec4e7d commit 999f86a928792cce1cb90fcfd7be249e37ec4e7d Author: Joel Einbinder <einbinder@chromium.org> Date: Fri Dec 15 00:13:24 2017 DevTools: Extract SnippetsPlugin from JavaScriptSourceFrame Bug: 778043 Change-Id: If62821bbd2140fc66af9985c11e98569d3b62ecc Reviewed-on: https://chromium-review.googlesource.com/773780 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#524250} [modify] https://crrev.com/999f86a928792cce1cb90fcfd7be249e37ec4e7d/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/999f86a928792cce1cb90fcfd7be249e37ec4e7d/third_party/WebKit/Source/devtools/front_end/sources/CSSPlugin.js [modify] https://crrev.com/999f86a928792cce1cb90fcfd7be249e37ec4e7d/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompilerPlugin.js [modify] https://crrev.com/999f86a928792cce1cb90fcfd7be249e37ec4e7d/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js [add] https://crrev.com/999f86a928792cce1cb90fcfd7be249e37ec4e7d/third_party/WebKit/Source/devtools/front_end/sources/SnippetsPlugin.js [modify] https://crrev.com/999f86a928792cce1cb90fcfd7be249e37ec4e7d/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js [modify] https://crrev.com/999f86a928792cce1cb90fcfd7be249e37ec4e7d/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js [modify] https://crrev.com/999f86a928792cce1cb90fcfd7be249e37ec4e7d/third_party/WebKit/Source/devtools/front_end/sources/module.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0920b5eecf51ca3b520098d09ef65460acba3407 commit 0920b5eecf51ca3b520098d09ef65460acba3407 Author: Joel Einbinder <einbinder@chromium.org> Date: Tue Apr 17 00:47:45 2018 DevTools: JavaScriptSourceFrame -> DebuggerPlugin This moves JavaScriptSourceFrame into a plugin, and completes the plugin initiative. Bug: 778043 Change-Id: I5908cfe46650fd50524a08b2e402d8ac6ce77cc9 Reviewed-on: https://chromium-review.googlesource.com/889692 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551193} [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-external-change-breakpoints.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager-listeners-count.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-ui-source-frame.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-restored-breakpoint.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/click-gutter-breakpoint.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/continue-to-location-markers-in-top-level-function.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/continue-to-location-markers.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/inline-scope-variables.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-execution-line.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-2.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-3.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/sources/dont-diverge-script-evaluated-twice.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-4.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/BUILD.gn [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/front_end/source_frame/SourcesTextEditor.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/front_end/sources/CSSPlugin.js [rename] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/front_end/sources/DebuggerPlugin.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/front_end/sources/JavaScriptCompilerPlugin.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/front_end/sources/SnippetsPlugin.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/front_end/sources/SourcesPanel.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/front_end/sources/SourcesView.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/front_end/sources/UISourceCodeFrame.js [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/front_end/sources/module.json [modify] https://crrev.com/0920b5eecf51ca3b520098d09ef65460acba3407/third_party/blink/renderer/devtools/front_end/sources_test_runner/DebuggerTestRunner.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffc418d98575770088e992d1e88bcd95d6395bea commit ffc418d98575770088e992d1e88bcd95d6395bea Author: Joel Einbinder <einbinder@chromium.org> Date: Fri Apr 20 00:41:09 2018 DevTools: Cleanup DebuggerPlugin This patch merges some variables together which were seperate inf JavaScriptSourceFrame, takes @unrestricted off of the plugins, and renames JavaScriptSourceFrame to DebuggerPlugin where appropriate in tests. Bug: 778043 Change-Id: If1d86f46afff1bf0af328090a15a5a1bc92726d7 Reviewed-on: https://chromium-review.googlesource.com/1015650 Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#552218} [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-external-change-breakpoints.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-ui-source-frame.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-navigation.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-restored-breakpoint.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-shifted-breakpoint.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/inline-breakpoint-with-sourcemap.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/no-pause-on-disabled-breakpoint.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/provisional-breakpoints.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debug-inlined-scripts.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-inline-breakpoint-decorations.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/WebKit/LayoutTests/http/tests/devtools/sources/inline-script-with-source-map.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/blink/renderer/devtools/front_end/sources/CSSPlugin.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/blink/renderer/devtools/front_end/sources/DebuggerPlugin.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/blink/renderer/devtools/front_end/sources/JavaScriptCompilerPlugin.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/blink/renderer/devtools/front_end/sources/SnippetsPlugin.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/blink/renderer/devtools/front_end/sources/UISourceCodeFrame.js [modify] https://crrev.com/ffc418d98575770088e992d1e88bcd95d6395bea/third_party/blink/renderer/devtools/front_end/sources_test_runner/DebuggerTestRunner.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4435c448310d3850f31c65509f2dfce32ddf594e commit 4435c448310d3850f31c65509f2dfce32ddf594e Author: Joel Einbinder <einbinder@chromium.org> Date: Fri Apr 20 05:41:34 2018 DevTools: Recycle SourceFrames on persistence binding Previously, when a network UISourceCode was open, and a persistence binding appeared, the user was transferred over to a new SourceFrame for the filesystem UISourceCode. This resulted in an annoying flicker, and caused a loss of undo history. Bug: 778043 Change-Id: Ie846f96d3c4f2553e8a78db5259f394e358f94fa Reviewed-on: https://chromium-review.googlesource.com/1015195 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#552267} [modify] https://crrev.com/4435c448310d3850f31c65509f2dfce32ddf594e/third_party/blink/renderer/devtools/front_end/sources/SourcesView.js [modify] https://crrev.com/4435c448310d3850f31c65509f2dfce32ddf594e/third_party/blink/renderer/devtools/front_end/sources/TabbedEditorContainer.js [modify] https://crrev.com/4435c448310d3850f31c65509f2dfce32ddf594e/third_party/blink/renderer/devtools/front_end/sources/UISourceCodeFrame.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4648e7b6dd93d98a98aba120f53d5e4c2358df37 commit 4648e7b6dd93d98a98aba120f53d5e4c2358df37 Author: Joel Einbinder <einbinder@chromium.org> Date: Tue Apr 24 22:26:27 2018 DevTools: Extract the gutter diff into GutterDiffPlugin Bug: 778043 Change-Id: I7f80eb1553eb48456441d5ccab6be903875bbcff Reviewed-on: https://chromium-review.googlesource.com/1023033 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553319} [modify] https://crrev.com/4648e7b6dd93d98a98aba120f53d5e4c2358df37/third_party/WebKit/LayoutTests/http/tests/devtools/sources/source-code-diff.js [modify] https://crrev.com/4648e7b6dd93d98a98aba120f53d5e4c2358df37/third_party/blink/renderer/devtools/BUILD.gn [modify] https://crrev.com/4648e7b6dd93d98a98aba120f53d5e4c2358df37/third_party/blink/renderer/devtools/front_end/source_frame/SourceCodeDiff.js [add] https://crrev.com/4648e7b6dd93d98a98aba120f53d5e4c2358df37/third_party/blink/renderer/devtools/front_end/sources/GutterDiffPlugin.js [modify] https://crrev.com/4648e7b6dd93d98a98aba120f53d5e4c2358df37/third_party/blink/renderer/devtools/front_end/sources/UISourceCodeFrame.js [modify] https://crrev.com/4648e7b6dd93d98a98aba120f53d5e4c2358df37/third_party/blink/renderer/devtools/front_end/sources/module.json
Comment 1 by einbinder@chromium.org
, Oct 24 2017