New issue
Advanced search Search tips

Issue 778041 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature
Proj-XR
Proj-XR-VR

Blocking:
issue 773882



Sign in to add a comment

VR Device Manager doesn't handle devices connecting and disconnecting

Project Member Reported by offenwanger@chromium.org, Oct 24 2017

Issue description

The assumption before was the devices couldn't be connected and disconnected (which is true in the case of phones), but since we're adding support for connected HMDs on Desktop this assumption is no longer true, and this behavior needs to be handled.
 
Components: Internals>VR
Status: Available (was: Untriaged)

Comment 3 by btebbs@chromium.org, Jun 19 2018

Labels: OS-Windows
Components: Internals>XR
Components: -Internals>XR Internals>XR>VR
Labels: -Pri-3 Pri-2
Components: Internals>XR
Removing Internals>VR component and remapping to Internals>XR
Components: -Internals>VR
Owner: billorr@chromium.org
Status: Started (was: Available)
out for review.  https://chromium-review.googlesource.com/c/chromium/src/+/1364332
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544

commit ca60fe109315de3d88e1bf9d5ade38b5aaf5f544
Author: Bill Orr <billorr@chromium.org>
Date: Thu Dec 13 00:24:50 2018

Detect and handle XR device connect/disconnect

This change finishes plumbing of device connection events from the devices
to the browser, and fixes handling in the WebXR implementation.

Bug:  789620 , 778041 
Change-Id: Iba9999c0b021261df23add4d1bb2826bd0764ed4
Reviewed-on: https://chromium-review.googlesource.com/c/1364332
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616118}
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/chrome/services/isolated_xr_device/xr_runtime_provider.cc
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/chrome/services/isolated_xr_device/xr_runtime_provider.h
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/device/vr/oculus/oculus_device.cc
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/device/vr/oculus/oculus_device.h
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/device/vr/openvr/openvr_device.cc
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/device/vr/openvr/openvr_device.h
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/third_party/blink/renderer/modules/xr/xr.cc

Status: Fixed (was: Started)

Sign in to add a comment