Rename supportsArcPlusPlus field |
|||
Issue descriptionThe field actually represents whether we are operating within ARC++, not whether the device supports ARC++. Since this code runs within normal Chrome (not ARC++), this field will always be false, so it isn't a useful field to keep.
,
Dec 6 2017
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2028a77332ce7c5a64174dfce23a1782b7c8212 commit e2028a77332ce7c5a64174dfce23a1782b7c8212 Author: Kyle Horimoto <khorimoto@google.com> Date: Thu Dec 07 00:31:34 2017 [CrOS Tether] Change "supportsArcPlusPlus" field name. The field was erroneously named. The field's meaning actually indicates whether enrollment was done through ARC++. It is possible to have multiple enrollments of a single device: one through native CrOS and one through ARC++. The new name is "isArcPlusPlusEnrollment". Bug: 778026 , 672263 Change-Id: I0be749e32e1569602efa30c5a9df768d7a45d15c Reviewed-on: https://chromium-review.googlesource.com/811830 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#522273} [modify] https://crrev.com/e2028a77332ce7c5a64174dfce23a1782b7c8212/components/proximity_auth/webui/proximity_auth_webui_handler.cc [modify] https://crrev.com/e2028a77332ce7c5a64174dfce23a1782b7c8212/components/proximity_auth/webui/resources/proximity_auth.html [modify] https://crrev.com/e2028a77332ce7c5a64174dfce23a1782b7c8212/components/proximity_auth/webui/resources/proximity_auth.js
,
Dec 7 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by khorimoto@chromium.org
, Oct 24 2017