New issue
Advanced search Search tips

Issue 778017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 769089



Sign in to add a comment

[iOS] Create feature flag for new fullscreen implementation

Project Member Reported by kkhorimoto@chromium.org, Oct 24 2017

Issue description

See go/bijou-fullscreen-migration for more details.
 
Blocking: 769089
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1945ef4a55b39436c21c42e9d09ed4f1656c1459

commit 1945ef4a55b39436c21c42e9d09ed4f1656c1459
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Thu Oct 26 03:57:26 2017

[iOS] Create directory for fullscreen code.

Bug:  778017 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I81408aa55e45eada321d44565a78c0d0f4a5947a
Reviewed-on: https://chromium-review.googlesource.com/736033
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511732}
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/tabs/BUILD.gn
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/browser_view_controller.mm
[add] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/fullscreen/BUILD.gn
[add] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/fullscreen/OWNERS
[rename] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/fullscreen/fullscreen_controller.h
[rename] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/fullscreen/fullscreen_controller.mm
[rename] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/fullscreen/fullscreen_controller_unittest.mm
[rename] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm
[add] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/location_bar_notification_names.h
[add] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/location_bar_notification_names.mm
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/overscroll_actions/BUILD.gn
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/browser/web/chrome_web_test.mm
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/test/BUILD.gn
[modify] https://crrev.com/1945ef4a55b39436c21c42e9d09ed4f1656c1459/ios/chrome/test/earl_grey/BUILD.gn

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/803840623f51cc616d37cc2f473e55dd1a320fce

commit 803840623f51cc616d37cc2f473e55dd1a320fce
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Sat Oct 28 01:20:37 2017

[iOS] Created feature flag for new Fullscreen.

This CL creates a new base::Feature that can be used to enable the new
fullscreen implementation.

Bug:  778017 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id54fc69e607e423c37cbfff0a831b4e2555ad1f9
Reviewed-on: https://chromium-review.googlesource.com/736690
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512364}
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/tabs/BUILD.gn
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/ui/DEPS
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/ui/fullscreen/BUILD.gn
[add] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/ui/fullscreen/DEPS
[add] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/ui/fullscreen/fullscreen_features.h
[add] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/ui/fullscreen/fullscreen_features.mm
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/ui/side_swipe/BUILD.gn
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/803840623f51cc616d37cc2f473e55dd1a320fce/ios/chrome/test/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment