New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778010 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Quic doesn't accept cross-origin Http2 server push

Project Member Reported by xingx@chromium.org, Oct 24 2017

Issue description

Chrome Version: Version 62.0.3202.62 (Official Build) (64-bit)
OS: gLinux

What steps will reproduce the problem?
(1) Start Chrome with below commandline to ask it to use Flywheel proxy: google-chrome --ignore-certificate-errors --disable-fre --clear-cookies --clear-cache  --disable-default-apps --no-experimes --no-first-run --user-data-dir=/tmp/chrometmp  --enable-spdy-proxy-auth  --data-reduction-proxy-experiment=test_nano_redirect_push
(2) Go to http://googleweblight.com/i?u=http://mahresult.nic.in, Chrome should receive pushed http://mahresult.nic.in
(3) Go to chrome://net-internals, check QUIC session of proxy.googlezip.net, you can see QUIC_SESSION_RST_STREAM_FRAME_SENT with error message QUIC_UNAUTHORIZED_PROMISE_URL, after receiving the PUSH_PROMISE from Flywheel, and thus the pushed resource is then rejected.

What is the expected result?
 - Quic should accept the pushed resource.

What happens instead?
 - Quic closes the serverpush stream.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Components: Internals>Network>DataProxy Internals>Network>QUIC

Comment 2 by xingx@chromium.org, Oct 24 2017

Description: Show this description
Cc: tbansal@chromium.org
Labels: Needs-Triage-M62
Cc: rsleevi@chromium.org
Components: Privacy
can you clarify why Chrome should do that? Is that what the spec says?
Labels: Needs-Feedback

Comment 7 by rch@chromium.org, Nov 2 2017

Cc: ckrasic@chromium.org
Cc: b...@chromium.org zhongyi@chromium.org
Owner: ckrasic@chromium.org
Status: Assigned (was: Untriaged)
+bnc, zhongyi

Discussed with rch@ and realized the issue is that QUIC's cross-origin logic isn't aware of trusted proxies.  The analogous code in HTTP/2 does support them:

https://codesearch.chromium.org/chromium/src/net/spdy/chromium/spdy_session.cc?rcl=9dbb222fa1919414fb9b799fa80fee5db77407a1&l=1587

It probably makes sense to lift that code into a helper that can be re-used by QUIC.
Refreshed during triage.

Comment 10 by bengr@chromium.org, Mar 21 2018

Refreshed during triage.
Status: WontFix (was: Assigned)
Not needed right now. Lets reopen if there is a need.

Sign in to add a comment