Simplify D-Bus usage in mount_extension_image |
||||
Issue descriptionmount_extension_image calls into imageloader but does so by using the raw libchrome D-Bus bindings. This leads to a lot of boilerplate that we can clean up. Since imageloader uses chromeos-dbus-bindings we can use the generated proxies from that instead, and this gets us some benefits like type-safety of the D-Bus calls.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/imageloader/+/a040ae1df5f6d94f784776f7dc9e3c32653b336f commit a040ae1df5f6d94f784776f7dc9e3c32653b336f Author: Eric Caruso <ejcaruso@chromium.org> Date: Wed Oct 25 19:13:29 2017 imageloader: split out proxy generation Nothing in imageloader proper relies on the proxy generation since it's implementing the adaptor. If we split out the proxy generation then we can use it more easily from other programs. BUG= chromium:778003 TEST=emerge, inspect buildroot Change-Id: Ib250451d375ab8604bc6617fd8290ca96d97fce9 Reviewed-on: https://chromium-review.googlesource.com/736322 Commit-Ready: Eric Caruso <ejcaruso@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/a040ae1df5f6d94f784776f7dc9e3c32653b336f/libimageloader-client.pc.in [add] https://crrev.com/a040ae1df5f6d94f784776f7dc9e3c32653b336f/imageloader-client.gyp [add] https://crrev.com/a040ae1df5f6d94f784776f7dc9e3c32653b336f/libimageloader-client-test.pc.in [modify] https://crrev.com/a040ae1df5f6d94f784776f7dc9e3c32653b336f/imageloader.gyp
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d4cce40431d0c36c8e830b53581620dd78e9c4e7 commit d4cce40431d0c36c8e830b53581620dd78e9c4e7 Author: Eric Caruso <ejcaruso@chromium.org> Date: Fri Oct 27 23:14:07 2017 container_utils: add imageloader-client to DEPEND We want to move this package off raw libchrome bindings so it can use generated bindings instead. BUG= chromium:778003 TEST=emerge Change-Id: I565f7e30263b4df3a490e166cc794006641b1dfe Reviewed-on: https://chromium-review.googlesource.com/736431 Commit-Ready: Eric Caruso <ejcaruso@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d4cce40431d0c36c8e830b53581620dd78e9c4e7/chromeos-base/container_utils/container_utils-9999.ebuild
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/19d46cde458a1fe5325f678bf027987077621ec0 commit 19d46cde458a1fe5325f678bf027987077621ec0 Author: Eric Caruso <ejcaruso@chromium.org> Date: Fri Oct 27 23:14:07 2017 container_utils: use imageloader-client for D-Bus bindings mount_extension_image does a bunch of raw libchrome D-Bus binding calls but we can simplify this by using generated bindings. CQ-DEPEND=CL:736431 BUG= chromium:778003 TEST=emerge, deploy and run vont container, try to run nonexistent container Change-Id: I1bdcca4bf44a58fcb450d4770cd9f13fa9985257 Reviewed-on: https://chromium-review.googlesource.com/736325 Commit-Ready: Eric Caruso <ejcaruso@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/19d46cde458a1fe5325f678bf027987077621ec0/container_utils/container_utils.gyp [modify] https://crrev.com/19d46cde458a1fe5325f678bf027987077621ec0/container_utils/mount_extension_image.cc
,
Oct 28 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Oct 25 2017