ChromeCleanerControllerTest has cryptic test names |
||
Issue descriptionSample of test names: [ RUN ] All/ChromeCleanerControllerTest.WithMockCleanerProcess/78 [ OK ] All/ChromeCleanerControllerTest.WithMockCleanerProcess/78 (36 ms) [ RUN ] All/ChromeCleanerControllerTest.WithMockCleanerProcess/79 [ OK ] All/ChromeCleanerControllerTest.WithMockCleanerProcess/79 (14 ms) [ RUN ] All/ChromeCleanerControllerTest.WithMockCleanerProcess/80 [ OK ] All/ChromeCleanerControllerTest.WithMockCleanerProcess/80 (13 ms) It's really hard to tell which combination of flags is case "80".
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74432d78565b24754cf06a29d8e442b7ceb65ffe commit 74432d78565b24754cf06a29d8e442b7ceb65ffe Author: Joe Mason <joenotcharles@chromium.org> Date: Tue Oct 31 17:16:56 2017 Check mocked ChromeCleanerController funcs aren't called at wrong times. Also format test names legibly. Bug: 778000 Change-Id: Ia38bf67f2913caa91631f2c131b6f50b9b60b2ba Reviewed-on: https://chromium-review.googlesource.com/736067 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#512856} [modify] https://crrev.com/74432d78565b24754cf06a29d8e442b7ceb65ffe/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc
,
Nov 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by vakh@chromium.org
, Oct 27 2017