New issue
Advanced search Search tips

Issue 777997 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Change locale modifications in test to use ScopedLocale

Project Member Reported by newcomer@chromium.org, Oct 24 2017

Issue description

Owner: newcomer@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/990e612ebcd677c133a6ffe5e5b4bc7eae1762b3

commit 990e612ebcd677c133a6ffe5e5b4bc7eae1762b3
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Nov 09 18:41:03 2017

cros replace home-baked ScopedRTL with ScopedRestoreICUDefaultLocale

Replace home-baked ScopedRTL and other Scoped RTL objects with
the more commonly used version.

Modify ctor of ScopedRestoreICUDefaultLocale to optionally accept a
locale code to set.

Bug:  777997 
Change-Id: I23bebd574b008b1f7e8d16f2be5dda780d46ba63
Reviewed-on: https://chromium-review.googlesource.com/742442
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515222}
[modify] https://crrev.com/990e612ebcd677c133a6ffe5e5b4bc7eae1762b3/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/990e612ebcd677c133a6ffe5e5b4bc7eae1762b3/base/test/icu_test_util.cc
[modify] https://crrev.com/990e612ebcd677c133a6ffe5e5b4bc7eae1762b3/base/test/icu_test_util.h
[modify] https://crrev.com/990e612ebcd677c133a6ffe5e5b4bc7eae1762b3/ui/views/view_unittest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment